From: Lee Jones <lee.jones@linaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Marek Szyprowski <m.szyprowski@samsung.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
Kukjin Kim <kgene@kernel.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 2/4] phy: exynos5: Remove duplicated defines of PHY register defines
Date: Wed, 8 Feb 2017 11:59:40 +0000 [thread overview]
Message-ID: <20170208115940.anjjpg7ygspca7tf@dell> (raw)
In-Reply-To: <20170127200510.4444-3-krzk@kernel.org>
On Fri, 27 Jan 2017, Krzysztof Kozlowski wrote:
> Phy drivers access PMU region through regmap provided by exynos-pmu
> driver. However there is no need to duplicate defines for PMU
> registers. Instead just use whatever is defined in exynos-regs-pmu.h.
>
> This reduces number of defines and allows removal of one header.
>
> Suggested-by: Marek Szyprowski <m.szyprowski@samsung.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/phy/phy-exynos-dp-video.c | 1 +
> drivers/phy/phy-exynos5-usbdrd.c | 1 +
> include/linux/mfd/syscon/exynos5-pmu.h | 22 ----------------------
Acked-by: Lee Jones <lee.jones@linaro.org>
> include/linux/soc/samsung/exynos-regs-pmu.h | 8 ++++++++
> 4 files changed, 10 insertions(+), 22 deletions(-)
>
> diff --git a/drivers/phy/phy-exynos-dp-video.c b/drivers/phy/phy-exynos-dp-video.c
> index 34b06154e5d9..d72193188980 100644
> --- a/drivers/phy/phy-exynos-dp-video.c
> +++ b/drivers/phy/phy-exynos-dp-video.c
> @@ -20,6 +20,7 @@
> #include <linux/phy/phy.h>
> #include <linux/platform_device.h>
> #include <linux/regmap.h>
> +#include <linux/soc/samsung/exynos-regs-pmu.h>
>
> struct exynos_dp_video_phy_drvdata {
> u32 phy_ctrl_offset;
> diff --git a/drivers/phy/phy-exynos5-usbdrd.c b/drivers/phy/phy-exynos5-usbdrd.c
> index 07ed608905ac..7c896d0cda18 100644
> --- a/drivers/phy/phy-exynos5-usbdrd.c
> +++ b/drivers/phy/phy-exynos5-usbdrd.c
> @@ -25,6 +25,7 @@
> #include <linux/mfd/syscon/exynos5-pmu.h>
> #include <linux/regmap.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/soc/samsung/exynos-regs-pmu.h>
>
> /* Exynos USB PHY registers */
> #define EXYNOS5_FSEL_9MHZ6 0x0
> diff --git a/include/linux/mfd/syscon/exynos5-pmu.h b/include/linux/mfd/syscon/exynos5-pmu.h
> index 02af8dece914..6108857ffcca 100644
> --- a/include/linux/mfd/syscon/exynos5-pmu.h
> +++ b/include/linux/mfd/syscon/exynos5-pmu.h
> @@ -13,34 +13,12 @@
> #define _LINUX_MFD_SYSCON_PMU_EXYNOS5_H_
>
> /* Exynos5 PMU register definitions */
> -#define EXYNOS5_HDMI_PHY_CONTROL (0x700)
> -#define EXYNOS5_USBDRD_PHY_CONTROL (0x704)
>
> /* Exynos5250 specific register definitions */
> -#define EXYNOS5_USBHOST_PHY_CONTROL (0x708)
> -#define EXYNOS5_EFNAND_PHY_CONTROL (0x70c)
> -#define EXYNOS5_MIPI_PHY0_CONTROL (0x710)
> -#define EXYNOS5_MIPI_PHY1_CONTROL (0x714)
> -#define EXYNOS5_ADC_PHY_CONTROL (0x718)
> -#define EXYNOS5_MTCADC_PHY_CONTROL (0x71c)
> -#define EXYNOS5_DPTX_PHY_CONTROL (0x720)
> -#define EXYNOS5_SATA_PHY_CONTROL (0x724)
>
> /* Exynos5420 specific register definitions */
> -#define EXYNOS5420_USBDRD1_PHY_CONTROL (0x708)
> -#define EXYNOS5420_USBHOST_PHY_CONTROL (0x70c)
> -#define EXYNOS5420_MIPI_PHY0_CONTROL (0x714)
> -#define EXYNOS5420_MIPI_PHY1_CONTROL (0x718)
> -#define EXYNOS5420_MIPI_PHY2_CONTROL (0x71c)
> -#define EXYNOS5420_ADC_PHY_CONTROL (0x720)
> -#define EXYNOS5420_MTCADC_PHY_CONTROL (0x724)
> -#define EXYNOS5420_DPTX_PHY_CONTROL (0x728)
> -
> -/* Exynos5433 specific register definitions */
> -#define EXYNOS5433_USBHOST30_PHY_CONTROL (0x728)
>
> #define EXYNOS5_PHY_ENABLE BIT(0)
> #define EXYNOS5_MIPI_PHY_S_RESETN BIT(1)
> #define EXYNOS5_MIPI_PHY_M_RESETN BIT(2)
> -
> #endif /* _LINUX_MFD_SYSCON_PMU_EXYNOS5_H_ */
> diff --git a/include/linux/soc/samsung/exynos-regs-pmu.h b/include/linux/soc/samsung/exynos-regs-pmu.h
> index 637ead0efd36..d861e757bef8 100644
> --- a/include/linux/soc/samsung/exynos-regs-pmu.h
> +++ b/include/linux/soc/samsung/exynos-regs-pmu.h
> @@ -349,6 +349,8 @@
>
> #define EXYNOS5_AUTO_WDTRESET_DISABLE 0x0408
> #define EXYNOS5_MASK_WDTRESET_REQUEST 0x040C
> +#define EXYNOS5_USBDRD_PHY_CONTROL 0x0704
> +#define EXYNOS5_DPTX_PHY_CONTROL 0x0720
>
> #define EXYNOS5_USE_RETENTION BIT(4)
> #define EXYNOS5_SYS_WDTRESET (1 << 20)
> @@ -502,6 +504,11 @@
> #define EXYNOS5420_KFC_CORE_RESET(_nr) \
> ((EXYNOS5420_KFC_CORE_RESET0 | EXYNOS5420_KFC_ETM_RESET0) << (_nr))
>
> +#define EXYNOS5420_USBDRD1_PHY_CONTROL 0x0708
> +#define EXYNOS5420_MIPI_PHY0_CONTROL 0x0714
> +#define EXYNOS5420_MIPI_PHY1_CONTROL 0x0718
> +#define EXYNOS5420_MIPI_PHY2_CONTROL 0x071C
> +#define EXYNOS5420_DPTX_PHY_CONTROL 0x0728
> #define EXYNOS5420_ARM_CORE2_SYS_PWR_REG 0x1020
> #define EXYNOS5420_DIS_IRQ_ARM_CORE2_LOCAL_SYS_PWR_REG 0x1024
> #define EXYNOS5420_DIS_IRQ_ARM_CORE2_CENTRAL_SYS_PWR_REG 0x1028
> @@ -639,6 +646,7 @@
> | EXYNOS5420_KFC_USE_STANDBY_WFI3)
>
> /* For EXYNOS5433 */
> +#define EXYNOS5433_USBHOST30_PHY_CONTROL (0x0728)
> #define EXYNOS5433_PAD_RETENTION_AUD_OPTION (0x3028)
> #define EXYNOS5433_PAD_RETENTION_MMC2_OPTION (0x30C8)
> #define EXYNOS5433_PAD_RETENTION_TOP_OPTION (0x3108)
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-02-08 13:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-27 20:05 [PATCH 0/4] phy/mfd/soc: exynos: Header cleanup Krzysztof Kozlowski
2017-01-27 20:05 ` [PATCH 1/4] phy: exynos4: Remove duplicated defines of PHY register defines Krzysztof Kozlowski
2017-02-08 11:58 ` Lee Jones
2017-01-27 20:05 ` [PATCH 2/4] phy: exynos5: " Krzysztof Kozlowski
2017-02-08 11:59 ` Lee Jones [this message]
2017-01-27 20:05 ` [PATCH 3/4] phy: exynos-mipi-video: Use consistent method to address phy registers Krzysztof Kozlowski
2017-01-27 20:05 ` [PATCH 4/4] phy: exynos: Use one define for enable bit Krzysztof Kozlowski
2017-02-08 11:59 ` Lee Jones
2017-01-30 9:13 ` [PATCH 0/4] phy/mfd/soc: exynos: Header cleanup Kishon Vijay Abraham I
2017-02-02 18:38 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170208115940.anjjpg7ygspca7tf@dell \
--to=lee.jones@linaro.org \
--cc=javier@osg.samsung.com \
--cc=kgene@kernel.org \
--cc=kishon@ti.com \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).