From: kbuild test robot <lkp@intel.com>
To: Kent Overstreet <kent.overstreet@gmail.com>
Cc: kbuild-all@01.org, Pavel Machek <pavel@ucw.cz>,
Mike Snitzer <snitzer@redhat.com>,
kernel list <linux-kernel@vger.kernel.org>,
axboe@fb.com, hch@lst.de, neilb@suse.de,
martin.petersen@oracle.com, dpark@posteo.net,
ming.l@ssi.samsung.com, dm-devel@redhat.com,
ming.lei@canonical.com, agk@redhat.com, jkosina@suse.cz,
geoff@infradead.org, jim@jtan.com, pjk1939@linux.vnet.ibm.com,
minchan@kernel.org, ngupta@vflare.org, oleg.drokin@intel.com,
andreas.dilger@intel.com
Subject: Re: [PATCH] block: Make rescuer threads per request_queue, not per bioset
Date: Wed, 8 Feb 2017 14:23:00 +0800 [thread overview]
Message-ID: <201702081403.MHVkdYmx%fengguang.wu@intel.com> (raw)
In-Reply-To: <20170207204510.qr2l2rg42ez2hobh@moria.home.lan>
[-- Attachment #1: Type: text/plain, Size: 3433 bytes --]
Hi Kent,
[auto build test WARNING on linus/master]
[also build test WARNING on v4.10-rc7]
[cannot apply to next-20170207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Kent-Overstreet/block-Make-rescuer-threads-per-request_queue-not-per-bioset/20170208-130414
config: x86_64-randconfig-x017-201706 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64
All warnings (new ones prefixed by >>):
In file included from include/uapi/linux/stddef.h:1:0,
from include/linux/stddef.h:4,
from include/uapi/linux/posix_types.h:4,
from include/uapi/linux/types.h:13,
from include/linux/types.h:5,
from include/uapi/linux/capability.h:16,
from include/linux/capability.h:15,
from include/linux/sched.h:15,
from include/linux/kasan.h:4,
from kernel/sched/core.c:29:
kernel/sched/core.c: In function 'sched_submit_work':
kernel/sched/core.c:3445:7: error: implicit declaration of function 'bio_list_empty' [-Werror=implicit-function-declaration]
!bio_list_empty(&tsk->bio_list->bios) &&
^
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> kernel/sched/core.c:3444:2: note: in expansion of macro 'if'
if (tsk->bio_list &&
^~
kernel/sched/core.c:3445:36: error: dereferencing pointer to incomplete type 'struct bio_plug_list'
!bio_list_empty(&tsk->bio_list->bios) &&
^
include/linux/compiler.h:149:30: note: in definition of macro '__trace_if'
if (__builtin_constant_p(!!(cond)) ? !!(cond) : \
^~~~
>> kernel/sched/core.c:3444:2: note: in expansion of macro 'if'
if (tsk->bio_list &&
^~
kernel/sched/core.c:3447:3: error: implicit declaration of function 'blk_punt_blocked_bios' [-Werror=implicit-function-declaration]
blk_punt_blocked_bios(tsk->bio_list);
^~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/if +3444 kernel/sched/core.c
3428
3429 /* causes final put_task_struct in finish_task_switch(). */
3430 __set_current_state(TASK_DEAD);
3431 current->flags |= PF_NOFREEZE; /* tell freezer to ignore us */
3432 __schedule(false);
3433 BUG();
3434 /* Avoid "noreturn function does return". */
3435 for (;;)
3436 cpu_relax(); /* For when BUG is null */
3437 }
3438
3439 static inline void sched_submit_work(struct task_struct *tsk)
3440 {
3441 if (!tsk->state || tsk_is_pi_blocked(tsk))
3442 return;
3443
> 3444 if (tsk->bio_list &&
3445 !bio_list_empty(&tsk->bio_list->bios) &&
3446 tsk->bio_list->q->rescue_workqueue)
3447 blk_punt_blocked_bios(tsk->bio_list);
3448
3449 /*
3450 * If we are going to sleep and we have plugged IO queued,
3451 * make sure to submit it to avoid deadlocks.
3452 */
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23909 bytes --]
next prev parent reply other threads:[~2017-02-08 6:24 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 10:49 4.4-rc: 28 bioset threads on small notebook Pavel Machek
2015-12-11 14:08 ` Mike Snitzer
2015-12-11 17:14 ` Pavel Machek
2016-02-20 17:40 ` 4.4-final: " Pavel Machek
2016-02-20 18:42 ` Pavel Machek
2016-02-20 19:51 ` Mike Snitzer
2016-02-20 20:04 ` Pavel Machek
2016-02-20 20:38 ` Mike Snitzer
2016-02-20 20:55 ` Pavel Machek
2016-02-21 4:15 ` Kent Overstreet
2016-02-21 6:43 ` Ming Lin-SSI
2016-02-21 9:40 ` Ming Lei
2016-02-22 22:58 ` Kent Overstreet
2016-02-23 2:55 ` Ming Lei
2016-02-23 14:54 ` Mike Snitzer
2016-02-24 2:48 ` Ming Lei
2016-02-24 3:23 ` Kent Overstreet
2016-02-23 20:45 ` Pavel Machek
2017-02-06 12:53 ` v4.9, 4.4-final: 28 bioset threads on small notebook, 36 threads on cellphone Pavel Machek
2017-02-07 1:47 ` Kent Overstreet
2017-02-07 2:49 ` Kent Overstreet
2017-02-07 17:13 ` Mike Snitzer
2017-02-07 20:39 ` Pavel Machek
2017-02-08 3:12 ` Mike Galbraith
2017-02-08 4:58 ` Kent Overstreet
2017-02-08 6:22 ` [PATCH] block: Make rescuer threads per request_queue, not per bioset kbuild test robot
2017-02-08 6:23 ` kbuild test robot [this message]
2017-02-08 6:57 ` v4.9, 4.4-final: 28 bioset threads on small notebook, 36 threads on cellphone Mike Galbraith
2017-02-08 16:34 ` Mike Snitzer
2017-02-09 21:25 ` Kent Overstreet
2017-02-14 16:34 ` [dm-devel] " Mikulas Patocka
2017-02-14 17:33 ` Mike Snitzer
2017-02-08 2:47 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201702081403.MHVkdYmx%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=agk@redhat.com \
--cc=andreas.dilger@intel.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=dpark@posteo.net \
--cc=geoff@infradead.org \
--cc=hch@lst.de \
--cc=jim@jtan.com \
--cc=jkosina@suse.cz \
--cc=kbuild-all@01.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=minchan@kernel.org \
--cc=ming.l@ssi.samsung.com \
--cc=ming.lei@canonical.com \
--cc=neilb@suse.de \
--cc=ngupta@vflare.org \
--cc=oleg.drokin@intel.com \
--cc=pavel@ucw.cz \
--cc=pjk1939@linux.vnet.ibm.com \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).