linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Yinghai Lu <yinghai@kernel.org>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend
Date: Wed, 8 Feb 2017 11:57:36 -0600	[thread overview]
Message-ID: <20170208175736.GB27298@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170207062101.GB791@wunner.de>

On Tue, Feb 07, 2017 at 07:21:01AM +0100, Lukas Wunner wrote:
> On Mon, Feb 06, 2017 at 04:15:02PM -0600, Bjorn Helgaas wrote:
> > On Mon, Feb 06, 2017 at 10:20:41PM +0100, Lukas Wunner wrote:
> > > On Mon, Feb 06, 2017 at 11:54:05AM -0600, Bjorn Helgaas wrote:
> > > > What is the hotplug event that causes generation of this wakeup event?
> > > 
> > > If you had read all e-mails in this thread or looked at the bugzilla
> > > entry I've created, you wouldn't have to ask this question.
> > 
> > I'm sorry, I don't necessarily have time to sort through all the
> > emails.  My idea is that the changelog should be a self-contained
> > justification for the patch.  The bugzilla is for supporting details
> > and future archaeologists.
> > 
> > > I think it's disappointing that you're asking me to jump through
> > > various hoops like creating a bugzilla entry, as well as threatening
> > > to revert my patch, but are unwilling to even look at the bugzilla
> > > entry or read the entire thread.  It is equally disappointing that
> > > the reporter of the regression was unwilling or unable to provide
> > > dmesg output for both machines so that we've got no real idea what
> > > we're dealing with.
> > 
> > I beg your pardon?  I don't think it's fair to malign Yinghai.  He's
> > tested at least two machines and at least two patches, and it's only
> > been two working days since he reported the problem.
> 
> I think the commercialization of Linux kernel development has put this
> open source project in a sorry state if an unpaid volunteer is told off
> because he expresses disappointment that a paid contributor is asking
> him to debug an issue on secret hardware using secret patches and not
> providing secret dmesg output.

Just let me be clear that I greatly appreciate all problem reports.
There's very little that I can actually test myself, so problem
reports from others are absolutely essential.

Often we don't get all the information we'd like, but I treat all
reports seriously.  For every report we get, there may be dozens or
hundreds of people who hit the same problem but do not have the time
or expertise to report it.

> > If you think a bugzilla is onerous
> 
> Hold on.  I didn't say a bugzilla is onerous, I said I'm disappointed
> that you're asking me to create one and then don't look at it.

I looked at it, and it had a few details, but no analysis of the
situation.  Ideally, I'm looking for a précis of the situation in
the changelog, with complete analysis and supporting details in the
bugzilla.

Bjorn

  parent reply	other threads:[~2017-02-08 17:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-06  5:54 [PATCH v2] PCI: pciehp: Don't enable PME on runtime suspend Lukas Wunner
2017-02-06 11:56 ` Rafael J. Wysocki
2017-02-06 17:54 ` Bjorn Helgaas
2017-02-06 21:20   ` Lukas Wunner
2017-02-06 21:27     ` Rafael J. Wysocki
2017-02-06 21:52     ` Rafael J. Wysocki
2017-02-07  6:26       ` Lukas Wunner
2017-02-07 16:15         ` Rafael J. Wysocki
2017-02-06 22:15     ` Bjorn Helgaas
2017-02-07  6:21       ` Lukas Wunner
2017-02-07 16:04         ` Rafael J. Wysocki
2017-02-08  4:23           ` Lukas Wunner
2017-02-08 12:03             ` Rafael J. Wysocki
2017-02-08 18:04             ` Bjorn Helgaas
2017-02-08 17:57         ` Bjorn Helgaas [this message]
2017-02-09  4:32           ` Lukas Wunner
2017-02-12 14:57             ` Lukas Wunner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170208175736.GB27298@bhelgaas-glaptop.roam.corp.google.com \
    --to=helgaas@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).