From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbdBIJCg (ORCPT ); Thu, 9 Feb 2017 04:02:36 -0500 Received: from mail.kernel.org ([198.145.29.136]:35914 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbdBIJCd (ORCPT ); Thu, 9 Feb 2017 04:02:33 -0500 Date: Thu, 9 Feb 2017 11:02:23 +0200 From: Leon Romanovsky To: SF Markus Elfring Cc: linux-rdma@vger.kernel.org, Doug Ledford , Hal Rosenstock , Sean Hefty , Steve Wise , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH 12/14] RDMA/cxgb4: Delete an unnecessary variable initialisation in create_qp() Message-ID: <20170209090223.GM6005@mtr-leonro.local> References: <0aff92fa-2891-333a-2e1e-ca309db2ec72@users.sourceforge.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mUkVHLrPAbedpyr7" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --mUkVHLrPAbedpyr7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 08, 2017 at 10:22:28PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Wed, 8 Feb 2017 21:07:07 +0100 > > The local variable "ret" will be set to an appropriate value a bit later. > Thus omit the explicit initialisation at the beginning in this function. > > Signed-off-by: Markus Elfring > --- > drivers/infiniband/hw/cxgb4/qp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c > index 373d66a511a8..ac63b1f70731 100644 > --- a/drivers/infiniband/hw/cxgb4/qp.c > +++ b/drivers/infiniband/hw/cxgb4/qp.c > @@ -202,7 +202,7 @@ static int create_qp(struct c4iw_rdev *rdev, struct t4_wq *wq, > int wr_len; > struct c4iw_wr_wait wr_wait; > struct sk_buff *skb; > - int ret = 0; > + int ret; The more clean approach will be to initialize this variable to -ENOMEM and remove rest "ret = -ENOMEM" from the function. > int eqsize; > > wq->sq.qid = c4iw_get_qpid(rdev, uctx); > -- > 2.11.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html --mUkVHLrPAbedpyr7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEkhr/r4Op1/04yqaB5GN7iDZyWKcFAlicMB0ACgkQ5GN7iDZy WKdC2w//TkD7Y7i9Zwj31zNfkyBr6PUPd61P2/QTaXGzPtIyIP/VplgjUqQ0yX2s g2hZkQt5aJL0Sm4hM7DPXjg0I3srbRpJVAKQLW3UFIoGNbv/cchGr42as6iJTTWa 386URqZqDiybHJI+vFFEPjiDmdpTX8LIsV7qauuNulHCHep5zC2AsoEbQkhb1NBy /a1M9IjSZXbOMLgZsyd2dwwcrL+UMb3gcSa0Zns35hMWnH6MsVJbGsp1nDrQdqQQ m4spCVqvZMaCQzT04eOAk67G8phdLL3C0XB7LPE7Do6Sacr/bHRyMbHjw8iD1GC0 7eIYRBqUm5r3gLxpBTCdQFF010ivYRU8rZmynW5mm3yC++HLw81LCjja0tF4Z3Mn s9lwuEVIGe3IjL4aq0KQ5A3AN9hCg5F2+V/OCW6JleO1DXo0XWk2KX7xM4LJ2nIe yiYBCOkwm6stIg/zLR9MEXoS5YwuojlwIhDd4hCF5bvIf2Ou/ONBKvRvn2dnz6pq cVPPyBLT6QLP7wWj43F2MAfnP3zIHPag4NuU28JxrTeko87NZ/NaimDAFehhCFt5 TLvVjNRv71DytejOqsnn8OURHzZ0qjz313L0VpJ5a6tJB+ZzJbgpYgrGpHCPGn5z 65kBk+/aPZ2eqxuabwWLMPxW7dkfB+q4jhfx/muTUuO+d9zKe/Q= =cArn -----END PGP SIGNATURE----- --mUkVHLrPAbedpyr7--