linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Russell King <linux@armlinux.org.uk>
Cc: linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Kees Cook <keescook@chromium.org>, Arnd Bergmann <arnd@arndb.de>,
	Kevin Hilman <khilman@baylibre.com>
Subject: [PATCH] ARM: multi_v7_defconfig: enable pstore configs
Date: Thu, 9 Feb 2017 12:52:50 -0800	[thread overview]
Message-ID: <20170209205250.GA118863@google.com> (raw)
In-Reply-To: <20170209195646.GA39738@beast>

It's useful to get testing on these features on various boards (e.g., on
KernelCI), and (when they're working) the ramoops feature is extremely
helpful for debugging live systems.

Signed-off-by: Brian Norris <briannorris@chromium.org>
---
+ ARM folks
- Linus

>From Kees's recent pull request:

On Thu, Feb 09, 2017 at 11:56:46AM -0800, Kees Cook wrote:
> Hi,
> 
> This pstore regression was just noticed. If I'm too late, this can land
> in v4.11 and -stable, but if the fix window is still open for v4.10, I'd
> love to see this fix pulled for v4.10.
> 
> Thanks!
> 
> -Kees
[...]
> ----------------------------------------------------------------
> Fix pstore regression (boot Oops) when ftrace disabled, from Brian Norris.
> 
> ----------------------------------------------------------------

I expect we aren't getting regular testing coverage (e.g., from
KernelCI, which has a few ARM-based Chromebooks in the lab [1], which
would have trivially caught the bug) because pstore is not enabled on
the multiplatform config that gets used there. Seems like a good idea,
so we can catch regressions like this automatically?

[1] https://kernelci.org/boot/rk3288-veyron-jerry/

 arch/arm/configs/multi_v7_defconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 028d2b70e3b5..74bdb89faff6 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -906,6 +906,10 @@ CONFIG_TMPFS=y
 CONFIG_SQUASHFS=y
 CONFIG_SQUASHFS_LZO=y
 CONFIG_SQUASHFS_XZ=y
+CONFIG_PSTORE=y
+CONFIG_PSTORE_CONSOLE=y
+CONFIG_PSTORE_PMSG=y
+CONFIG_PSTORE_RAM=y
 CONFIG_NFS_FS=y
 CONFIG_NFS_V3_ACL=y
 CONFIG_NFS_V4=y
-- 
2.11.0.483

  reply	other threads:[~2017-02-09 20:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 19:56 [GIT PULL] pstore fix for v4.10-rc8 Kees Cook
2017-02-09 20:52 ` Brian Norris [this message]
2017-02-16 16:22   ` [PATCH] ARM: multi_v7_defconfig: enable pstore configs Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170209205250.GA118863@google.com \
    --to=briannorris@chromium.org \
    --cc=arnd@arndb.de \
    --cc=keescook@chromium.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).