From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752590AbdBJPX4 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 10:23:56 -0500
Received: from mga07.intel.com ([134.134.136.100]:46595 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751454AbdBJPXw (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 10:23:52 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.35,142,1484035200"; 
   d="scan'208";a="932387211"
Date: Fri, 10 Feb 2017 17:17:08 +0200
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@01.org, Greg KH <gregkh@linuxfoundation.org>,
        Guenter Roeck <linux@roeck-us.net>, Oliver Neukum <oneukum@suse.com>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        Felipe Balbi <felipe.balbi@linux.intel.com>,
        linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: typec: fix ptr_ret.cocci warnings
Message-ID: <20170210151708.GA19421@kuha.fi.intel.com>
References: <201701310115.zBz8Tqzh%fengguang.wu@intel.com>
 <20170130173832.GA5608@lkp-ib03.lkp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170130173832.GA5608@lkp-ib03.lkp.intel.com>
User-Agent: Mutt/1.7.1 (2016-10-04)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 31, 2017 at 01:38:34AM +0800, kbuild test robot wrote:
> drivers/usb/typec/typec.c:1249:1-3: WARNING: PTR_ERR_OR_ZERO can be used
> 
> 
>  Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
> 
> Generated by: scripts/coccinelle/api/ptr_ret.cocci
> 
> CC: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
>  typec.c |    4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> --- a/drivers/usb/typec/typec.c
> +++ b/drivers/usb/typec/typec.c
> @@ -1246,9 +1246,7 @@ EXPORT_SYMBOL_GPL(typec_unregister_port)
>  static int __init typec_init(void)
>  {
>  	typec_class = class_create(THIS_MODULE, "typec");
> -	if (IS_ERR(typec_class))
> -		return PTR_ERR(typec_class);
> -	return 0;
> +	return PTR_ERR_OR_ZERO(typec_class);

Thanks kbuild test robot. I'll fix that.

-- 
heikki