From: Bjorn Helgaas <helgaas@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org,
Andreas Noever <andreas.noever@gmail.com>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v5 1/8] PCI: Recognize Thunderbolt devices
Date: Fri, 10 Feb 2017 11:42:50 -0600 [thread overview]
Message-ID: <20170210174250.GD29169@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <20170129002616.GA28225@wunner.de>
On Sun, Jan 29, 2017 at 01:26:16AM +0100, Lukas Wunner wrote:
> On Sat, Jan 28, 2017 at 03:52:08PM -0600, Bjorn Helgaas wrote:
> > On Sun, Jan 15, 2017 at 09:03:45PM +0100, Lukas Wunner wrote:
> > > +static void set_pcie_vendor_specific(struct pci_dev *dev)
> >
> > This is very specific to Thunderbolt, so let's name it something that
> > conveys that information. The fact that we use a vendor-specific
> > capability to figure it out isn't really relevant in the caller.
>
> I thought that we may have the necessity in the future to parse other
> VSECs on device probe, so I gave the function this generic name.
>
> Think about it, every VSEC that needs to be parsed needs the while loop
> below. It's more efficient to have only a single while loop that handles
> *all* VSECs at once.
>
> If someone needs to parse another VSEC, they just add it to this function.
> So IMO the way I've solved it is preferable to just adding a Thunderbolt-
> specific function.
>
> Are you sure you want this renamed? (y/n)
Sorry for the delay; I missed this question. If this has already been
merged somewhere as-is, that's fine. If you repost it for any reason,
I would prefer to rename it so it reflects the functionality rather
than the source of the information. This isn't a performance path, so
readability is more important than optimization.
Bjorn
next prev parent reply other threads:[~2017-02-10 18:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-15 20:03 [PATCH v5 0/8] Runtime PM for Thunderbolt on Macs Lukas Wunner
2017-01-15 20:03 ` [PATCH v5 8/8] thunderbolt: Runtime suspend NHI when idle Lukas Wunner
2017-01-15 20:03 ` [PATCH v5 6/8] PM / sleep: Define constant for direct_complete Lukas Wunner
2017-01-15 20:03 ` [PATCH v5 3/8] PCI: Don't block runtime PM for Thunderbolt host hotplug ports Lukas Wunner
2017-01-16 10:29 ` Mika Westerberg
2017-01-28 23:00 ` Bjorn Helgaas
2017-02-10 18:39 ` Bjorn Helgaas
2017-02-12 17:13 ` Lukas Wunner
2017-02-13 12:17 ` Rafael J. Wysocki
2017-01-15 20:03 ` [PATCH v5 7/8] thunderbolt: Power down controller when idle Lukas Wunner
2017-01-28 23:32 ` Bjorn Helgaas
2017-02-12 16:31 ` Lukas Wunner
2017-02-13 22:57 ` Bjorn Helgaas
2017-01-15 20:03 ` [PATCH v5 1/8] PCI: Recognize Thunderbolt devices Lukas Wunner
2017-01-28 21:52 ` Bjorn Helgaas
2017-01-29 0:26 ` Lukas Wunner
2017-02-06 6:09 ` Lukas Wunner
2017-02-10 17:42 ` Bjorn Helgaas [this message]
2017-02-12 16:50 ` Lukas Wunner
2017-01-15 20:03 ` [PATCH v5 2/8] PCI: Allow runtime PM on Thunderbolt ports Lukas Wunner
2017-01-28 22:09 ` Bjorn Helgaas
2017-01-30 7:15 ` Rafael J. Wysocki
2017-02-10 17:57 ` Bjorn Helgaas
2017-01-15 20:03 ` [PATCH v5 4/8] Revert "PM / Runtime: Remove the exported function pm_children_suspended()" Lukas Wunner
2017-01-15 20:03 ` [PATCH v5 5/8] PM: Make requirements of dev_pm_domain_set() more precise Lukas Wunner
2017-01-28 23:14 ` Bjorn Helgaas
2017-01-19 10:38 ` [PATCH v5 0/8] Runtime PM for Thunderbolt on Macs Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210174250.GD29169@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=andreas.noever@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).