From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753595AbdBJTGT (ORCPT ); Fri, 10 Feb 2017 14:06:19 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:46893 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752164AbdBJTGP (ORCPT ); Fri, 10 Feb 2017 14:06:15 -0500 Date: Fri, 10 Feb 2017 09:52:33 -0800 From: Shaohua Li To: Michal Hocko CC: , , , , , , , , , Subject: Re: [PATCH V2 6/7] proc: show MADV_FREE pages info in smaps Message-ID: <20170210175232.GE86050@shli-mbp.local> References: <1239fb2871c55d63e7e649ad14c6dabaef131d66.1486163864.git.shli@fb.com> <20170210133040.GN10893@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170210133040.GN10893@dhcp22.suse.cz> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::d:7cca] X-ClientProxiedBy: BN6PR02CA0062.namprd02.prod.outlook.com (10.175.94.152) To BN6PR15MB1635.namprd15.prod.outlook.com (10.175.131.9) X-MS-Office365-Filtering-Correlation-Id: 44e509e3-a343-4f2d-b86f-08d451dd9aec X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1635; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1635;3:4mJqdPh6bCCfjpKPfPxyhZZaAImzq6Q5q1ERlVr1udo09ucAwH5iS/5/je6nfMH9+YNB294guuD331Lni85lZCEUIXRKmq6dWwkkAKTkSSNfvb8Hd+pABhh6nZSsAEd+VHCUJHtXEFMefo44TzCdfUPyhyUBygn2DrjDb46MQlILIFphkADGTJXYKL0xBRJAgpLuxfpwmxxXfQmFr21w4gzzc5vilapZQro9D021REsUXtwr8GL4Bpl185IKKwAT0tNgi7WcdGCLHXjokifk+A==;25:/81J8zuMxTx2A3Zgqn8VB1vb/P6Ti7cEVeWy1sg9WTwykVJvX8cpSuAwUyk8S/6/D1aykkRK1oIioSb941LlUCDL+kmoqgdLDUYPKECu5yLwo8+Wh/AoL9VdvTZ4oiDIUiEYt69uziDQCVa3qTpCRIkh3pGTp8KsAiKvasdBZt6fqiBiCe+Xf9KTwVrhadklmpiHgyZ9YPnl2fTVYQ0eyr8B/63Z6WxGeOk6Ms9eF5g6a78y0lfNL5hXL+S4hg+kjXCeYnAHCwlzVG52irfvZO0iHuKxU6IViSMaKyvsTNEmnHHnJt0fbh+hhJMw2xR/QaJ+KVQikuYKxSU8ohToUpXx8dOiJO9E02IzLcxbbllXs5YDbtKZPW7MLidF1/JFIngbClE9o8AsIJ6hiiTsB4ic8aqnxVl1/PtpkaMzZa/mOdrGzWoaaWfwSum6ltdRB+t/2JKPVEGYB0d7ebLzSg== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1635;31:6QhqFGqXGhTfFVO6dGZHdQRSxcEv+4R1P5rKAhsuOsL8IQz5sV2Eq7FltC8EOaDdTERcsMmpmLEF1gs0HCHQPexvGSsxfe/JB4y9tRgmaqTLs8V1OjDBpjAgMBAYXUc1gFyTRlSHZ1h39jYBhLxs3un+D1dYk/wwtUBKBq3Xy42KWL3W6DVNiohLe+ln811FSUI5fO/Fj3xH7UWHMYGfYt83v6CPul5os/HXGopZ5SPT3mu0i6ivtPYj2V68PAsi;20:Wdk51V/wzKGT5N9qOTzThHlyAJmTUmlxNZaDbGtZ24+OXCo45UwtwXTsLXsUuwD0n3N7FJoE4JzS0mXHGREqw/b4vbcu4ncna+Dgj4mmuwy9L2oYyhhfpa3Ynyx/53OxYi5GyswV5FlLtgJlW01SYRgHtQMfgbpkn4l2UcXH2DBAohZd0DagcfHgLxyoIv3c7iBIbdu5wxPL8zR4T3jR2j+pUJPwhKegWhmngNkLbeMT8JO53WC+IBr6Eosov3CX52XaeE4MxvZpy77NoOYOhBmxAFLEcg5lf8hJzmRyb+Se/MX/jGuPfr/fZAMW8tJwVBXzm8yMNzTj4chxEMhWFgHMtbI3R9g+4rgvaE6HpmgGVw2a997/tuH1iLZu14yC0Hw35wSTAgFB1y+qbLJp7vZ/tLdsJJOlQ5oZ8LZ1PrzIEUJFUZkOA0XalXSbEEQFIZT34OCD441ryvGjcCW4SeWaCY4HTg4XhJexkImNQtcOapFc6Z7SeD9+sv1C4ehY X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123558025)(20161123564025)(6072148);SRVR:BN6PR15MB1635;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1635; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1635;4:+4o2ZXCre5VLT7eMxc8eTbMdgSUOkKuHbFfh+78G9xh4f/EJZ7n+DayDi1Chz5CnAsaZL4ZUHx7IkSgwOUZOvSNC/vRwJjbihDmVJUAXMmeEViMA+2WhckQb84R84T6WmfRzdvwW5pwwrfDQztajSWsN5PmED9fJttuBK+EQYmkbruSNtZiNhausR3OW27oZxs/1d8s42K1BxMZHJ5d2SiwA4gRffnpB9tnjYmM7YdLT9+t/yUhnZax3iqO7gjB9qtRw00DrNJnLZ+zviRX22h3slkKk44xhoqKg46daFMkT+akGRLo4y6U5xcBVJ0VF5WsOUOjeAxkitURxHhvHQdTK/qFLEZFlddXSXdBNVgPaKknOcLWdeeuD0GZqaxJLz/4JG/fS8MGpIhZeyskZxcfY8cC7VUnugOnF+ipL858NV2sFBCduIUt2Ulk7JqXbCz3DTnHYFGCRVCGuXXs4Q2ik9x9BVvC1bJEsxsfAXaceOSiq3fn0035UdY30jKMoVJaU1jBp21xGEak1RtvSvcObCYUp2at5scGgE2xa7MtKqB+OUfD1qk9RbgMdKgQdad/YnjHFXW0wGw7HqdZXxQrDC/t9Jo7kMRtTpoNOngyKV/ZrbCts7KxicO10OKugbQixU+UpxlUI2johQSYHe3RablsL6/Laem8kbzvI8CbluBzUZuGpxDBcRnyDsRhQ X-Forefront-PRVS: 0214EB3F68 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39830400002)(39410400002)(39450400003)(24454002)(199003)(377424004)(189002)(33656002)(98436002)(2906002)(6916009)(50466002)(305945005)(101416001)(54356999)(50986999)(7736002)(7416002)(92566002)(76176999)(4326007)(46406003)(86362001)(6666003)(42186005)(106356001)(47776003)(105586002)(189998001)(97736004)(81156014)(81166006)(6116002)(8676002)(4001350100001)(53936002)(5660300001)(38730400002)(110136004)(6246003)(68736007)(54906002)(229853002)(39060400001)(6506006)(2950100002)(23726003)(25786008)(97756001)(55016002)(9686003)(83506001)(1076002)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1635;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR15MB1635;23:2NjuoMKJmfllr++2E6JewvAM8dO3FtMgq3I6L/9I2?= =?us-ascii?Q?sCYVlvbEPLZOxcAY17tSREW4AffXmgnDVNJRUmGttaI2bUdTrjKWpFpuUf4T?= =?us-ascii?Q?bq7vV1kwR7e66Q63nCxIYnYG2sYkg9IBJfeOoIv1Y5+OsUUsVHQs5IOrJ16z?= =?us-ascii?Q?Yz2nAlxsEO7loCEzhk0Goi6de83/P7wfi1h3N2zuya+vu+Newhbr5R3oC/rZ?= =?us-ascii?Q?DZRoLvc7ylCgmjX9fRNLz2TIjWEprKN6JbZRpv7hNov6ZatJx9kcZKRSRAG2?= =?us-ascii?Q?5hDC05EyLjd6OqIQ1RwDDGz9LIcjy+Pnitk4v1GNafcy8EbauxC1urcguWZK?= =?us-ascii?Q?dxDpmFhf+vvjH9hQVelxWaQGb7sLnO6F9BE46SE+41k1HQ3xSDTWszi88I8K?= =?us-ascii?Q?IPJKHRquVg92H7qfTtI1xwpLl6eQyFT1J4AKWiFr3MN3ikmwtzNZGOrC6kQj?= =?us-ascii?Q?G/DKt9t2o8ISGMi8C1HBMxZqVyNS/DRHbITxdlLTTARLZdMTQVsdegtA0A3h?= =?us-ascii?Q?mk3C68ES6ovLP/sLubgeuq1vVvB4Tz8xwc5fFjaaKFGFdiwG0BZ21kkzipeB?= =?us-ascii?Q?18b7hfGe70HS+1yFlhQBwWMxaLyCNmjTirpnY69Ksl+S1u35uGatpB0QXtt7?= =?us-ascii?Q?AAhCv6pxu0eXr72RJu2dmbIphMW3Ryzb9NaHGnfQpu9uEreHkLFCsp5y3kCT?= =?us-ascii?Q?j+mu2rJp6cXYq5KbELVMynXgod69S634y+a892NfszOHGVw/rTOV69Iy3LYh?= =?us-ascii?Q?kX/Rdn/5xgQMPbtlWubfkidz46a+0kCphRjjAe239TjVv9uGr2AiLQq6+DSK?= =?us-ascii?Q?aKXJQVhiLw8xCG4pWX3/5HAI/Qf0a5D58FSoz0WVgzqHNTguCxuUaIGVCdpl?= =?us-ascii?Q?sU/SEW0Go4QuvmHkCYPqsoORBoB6GMiS/gvbNT0JYvHTa5vKN/fHZ6SN5vpo?= =?us-ascii?Q?doNx1bl2IZWhsFqdTESU+Us4RtdyFsgeWn66UwwkCCriH75jKNUOUShs9kW2?= =?us-ascii?Q?54FgM4gAed4m/No9K6fjnRpV1/okDl7aFoQexdkWggNcG0jexqgPAWPMtHVV?= =?us-ascii?Q?ehJGWCH56vrrQzPhEaIiuRgRS9q3xCOzEDtAXQYaZ7hHSrxznHpXHl8c0p2B?= =?us-ascii?Q?fmPwzf9891cr8KvqqbXQhEx5RIMJfGCcIsb37+jI2nZ1XANWt/Gbg6rcmfEl?= =?us-ascii?Q?YfHOQd3dlJW2A0aFL5ZuoWoFAbjBy4I2QgBw41mMuVQTM0OpA4CMuOm3wppL?= =?us-ascii?Q?f12NQD2BG0VBYru6WmyiQz2JitgfMD908wW7Dw7aq+1yqzS90m1fF3Bp1g7p?= =?us-ascii?Q?qIqm/3pSXxUSm7p4toESDmf4QjOZGF+MSQB5d4BR9KlnZHydcihGncPS/edF?= =?us-ascii?Q?gHX1/FyXZMACnmhC3M+Ruzvu3E=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1635;6:ivgLjLbmZYn9ZEiKDpPy70EmyG7cCECc5N+a96b1AbVbLHUvg5EU1gKcLzAiej0v0svc0ynlrILFIvZLLuGfO4ghZ1rTmdLy0lNCJ8ycmOnwgEuvEMJnA8KlBqiC4lmUlqWUx6eT43GECQ+1uch+Bme+13U/sN+UkZcqwpF6CvSxRG1ZY53Pr30NV6mQbN/6QVCmd7rhHwtieG0o5HHX87baNIydeHAUVYZcrXqASHInjYQPNs9EArTywH5RaiayjNzNLB9iDxhsnesvACLNNC9OCFnV5RtYBZL5AKVIt2TLxoT1zvULg/MVMKb0bwR+94ksv9fqUwjioaGX7Oi85xs7A7wUjZ2PMvkGkdzBFRW9SHqgcP+WuS30HNdc2pky9G6J5guFLvgOQcVdJLUKYw==;5:Yy08sLLVpN3lPuB0UvVdoHLdt2/tLLyDFw3clTcjSGK5SkwVCnwdd1gt3CyMalvL3TxBR8n4O753KNU/VOBBA/d+WkTQ95b+HQVVA9ORyOLcLu82W+aa6dsS0wxGJzBGrNn5Q4LPPdl0PzVi5gVLKA==;24:1FBfcugGb0z/1gsovjMmtIFl10n58dG8FucEE5ZWf9Tq+b3Flw4YgmNUT10iTv0Yw4dI/tqHMthU/TLmtX3N0adY8nPMC+Zx9+zENDt4i4I= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1635;7:QiczLYi9llR0r/AcfNQQFJQ6KQx1H8UjiuPeBxpy6vlFZrdc7tiAezNYDx38Q2RqWFWX7bPee6L40D/O3tN3mPxaIB1v8tPlIa3qPZKu+6LdZ40JIypdev3bKtXv52siYUgYIM/w2+Sp7VIiYcFSrRigaXE+CWVg5D4Avf6qZXlH1h0WuIj9lER73qVxZv/faCRt49Bh42S4Lpew7tXDqWF05TlnULgBrfWbljlunTzerghXwceSjPW8uVEtkqOJ6CcJgeXRN1Fz/+V1cnd4ntjRor2OThXgxLQ0oT9wzjIzTE8L22IyU0ZL754tQ+gV1zeYhbGLy7Sy9tHtOfti9XL1BAn15uZlEItJI8LzGXLKt3KhLgCxfNcJ6PJBG+01s0IHx0BQKeVsX32RaTPkfizCIKmohAwhdkHw9EyHJlZ562i9fha3OoXkOeIJlg9JiwNmJQyyIDV3a0b/tr2/d6akO8frTBhigt/qBjbuZuu7By3jC0e8ktvyw5WQVDrFVZvI3fLQw2FOTHjwMf/21Q==;20:w75PYtzfQF0nSpRJmOYHhy3fMOC+SYVNheuX2z/smhe81X1JJp2OdTyAr0yUj9e60/Uar1NOxvGnPFwpjLStaLVYksljhLxKY7WeFE0TARdqS3K9SLeUIIbUGWVNO+567W6Vx42aAjjk3sgDn2QyAZsoazAdUsXMWaDcnsYNFjs= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Feb 2017 17:52:38.2809 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1635 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-10_07:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 02:30:40PM +0100, Michal Hocko wrote: > $DESCRIPTION_OF_YOUR_USECASE_GOES_HERE > > Moreover Documentation/filesystems/proc.txt should be updated as well. > > Other than that, the patch looks good to me. Ok, will add more description and add doc for proc.txt. I don't have solid use case for this though. It's consistent with other info we exported to userspace and mostly for diagnosing purpose. Thanks, Shaohua > On Fri 03-02-17 15:33:22, Shaohua Li wrote: > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Johannes Weiner > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Signed-off-by: Shaohua Li > > after the description is added and documentation updated > Acked-by: Michal Hocko > > > --- > > fs/proc/task_mmu.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > > > diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c > > index ee3efb2..8f2423f 100644 > > --- a/fs/proc/task_mmu.c > > +++ b/fs/proc/task_mmu.c > > @@ -440,6 +440,7 @@ struct mem_size_stats { > > unsigned long private_dirty; > > unsigned long referenced; > > unsigned long anonymous; > > + unsigned long lazyfree; > > unsigned long anonymous_thp; > > unsigned long shmem_thp; > > unsigned long swap; > > @@ -456,8 +457,11 @@ static void smaps_account(struct mem_size_stats *mss, struct page *page, > > int i, nr = compound ? 1 << compound_order(page) : 1; > > unsigned long size = nr * PAGE_SIZE; > > > > - if (PageAnon(page)) > > + if (PageAnon(page)) { > > mss->anonymous += size; > > + if (!PageSwapBacked(page)) > > + mss->lazyfree += size; > > + } > > > > mss->resident += size; > > /* Accumulate the size in pages that have been accessed. */ > > @@ -770,6 +774,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > "Private_Dirty: %8lu kB\n" > > "Referenced: %8lu kB\n" > > "Anonymous: %8lu kB\n" > > + "LazyFree: %8lu kB\n" > > "AnonHugePages: %8lu kB\n" > > "ShmemPmdMapped: %8lu kB\n" > > "Shared_Hugetlb: %8lu kB\n" > > @@ -788,6 +793,7 @@ static int show_smap(struct seq_file *m, void *v, int is_pid) > > mss.private_dirty >> 10, > > mss.referenced >> 10, > > mss.anonymous >> 10, > > + mss.lazyfree >> 10, > > mss.anonymous_thp >> 10, > > mss.shmem_thp >> 10, > > mss.shared_hugetlb >> 10, > > -- > > 2.9.3 > > > > -- > Michal Hocko > SUSE Labs