From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052AbdBKXj0 (ORCPT ); Sat, 11 Feb 2017 18:39:26 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:33923 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdBKXjY (ORCPT ); Sat, 11 Feb 2017 18:39:24 -0500 Date: Sun, 12 Feb 2017 00:39:21 +0100 From: Alexandre Belloni To: Wei Yongjun Cc: Alessandro Zummo , Maxime Ripard , Chen-Yu Tsai , Wei Yongjun , rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH -next] rtc: sun6i: Fix return value check in sun6i_rtc_clk_init() Message-ID: <20170211233921.brhtcoaozzhyw2wn@piout.net> References: <20170209001613.21665-1-weiyj.lk@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209001613.21665-1-weiyj.lk@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/02/2017 at 00:16:13 +0000, Wei Yongjun wrote: > From: Wei Yongjun > > In case of error, the function of_io_request_and_map() returns ERR_PTR() > and never returns NULL. The NULL test in the return value check should > be replaced with IS_ERR(). > > Fixes: 847b8bf62eb4 ("rtc: sun6i: Expose the 32kHz oscillator") > Signed-off-by: Wei Yongjun > --- > drivers/rtc/rtc-sun6i.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com