From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752312AbdBMSBo (ORCPT ); Mon, 13 Feb 2017 13:01:44 -0500 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:45968 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752231AbdBMSBl (ORCPT ); Mon, 13 Feb 2017 13:01:41 -0500 Date: Mon, 13 Feb 2017 18:01:29 +0000 From: Mark Brown To: Dmitry Torokhov Cc: Liam Girdwood , Guenter Roeck , linux-kernel@vger.kernel.org Message-ID: <20170213180129.wutjitdr72klhxwu@sirena.org.uk> References: <20170213023249.GA27688@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jmfjdnpccciqzniy" Content-Disposition: inline In-Reply-To: <20170213023249.GA27688@dtor-ws> X-Cookie: Disks travel in packs. User-Agent: NeoMutt/20161126 (1.7.1) X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5::3 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2] regulator: devres: introduce managed enable and disable operations X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --jmfjdnpccciqzniy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Feb 12, 2017 at 06:32:49PM -0800, Dmitry Torokhov wrote: > v2: restored lost regulator_disable() stub > Mark, note that there is also patch introducing devm_clk_prepare() and > devm_clk_prepare_enable() that Russell did not hate so I think it will > get applied eventually. I believe lack of CLK methods was cited as a > reason for not having managed enable for regulators. No, that's never been an issue. The concern is partly that nobody bothered writing the patch but also that it gets messy over suspend and resume since you end up with drivers either doing explicit releases of managed resources (which is not normally a good pattern) or mixing managed and unmanaged access to the same resource which is also fun. =20 --jmfjdnpccciqzniy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAlih9HkACgkQJNaLcl1U h9BYsgf/XYAna35gdHh2owQnH1R2hKbrZ4CT7884ZxVXHAfuUbv88iVtFk4T7XZX ODv7pmuwn/XsoecEMfx6COg56lV2K51W05E43MfA61qpoUdveSnZPb1GDe6JcVDW uc+CJbaeSX904XYA77bz9C4Jxote3FFpY33nvO2eEUdzTCHubormpM6USze1Y3pD WNMdyDIBf/iLcD7dQr3oWZmfdgJhWEt7xYjfJ6hsUC87dYafKv9jbhShpGutpiWN UsmyOg8qXfvfm1yhano0SWw4IBQsZiKSF3Ceh8k14AwPSA3rAuty9aqLtMITvJFW qOuICRahNTZnWy79Wj++GwyKGqAsuw== =jA5E -----END PGP SIGNATURE----- --jmfjdnpccciqzniy--