From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754410AbdBNTor (ORCPT ); Tue, 14 Feb 2017 14:44:47 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:59274 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753370AbdBNToQ (ORCPT ); Tue, 14 Feb 2017 14:44:16 -0500 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E8FDA60D35 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Tue, 14 Feb 2017 11:44:08 -0800 From: Stephen Boyd To: Dmitry Torokhov Cc: Russell King - ARM Linux , Guenter Roeck , Michael Turquette , Viresh Kumar , Andy Shevchenko , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] clk: add more managed APIs Message-ID: <20170214194408.GW25384@codeaurora.org> References: <20170128184047.GA24957@dtor-ws> <20170128190309.GN27312@n2100.armlinux.org.uk> <20170128192207.GA38136@dtor-ws> <64ed0890-14f6-42ff-66b1-60f7b3d7d02f@roeck-us.net> <20170128233911.GO27312@n2100.armlinux.org.uk> <20170129180743.GA10917@dtor-ws> <20170130185551.GM8801@codeaurora.org> <20170131005713.GA35974@dtor-ws> <20170207035151.GA18296@dtor-ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170207035151.GA18296@dtor-ws> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/06, Dmitry Torokhov wrote: > On Mon, Jan 30, 2017 at 04:57:13PM -0800, Dmitry Torokhov wrote: > > When converting a driver to managed resources it is desirable to be able to > > manage all resources in the same fashion. This change allows managing clock > > prepared and enabled state in the same way we manage many other resources. > > > > This adds the following managed APIs: > > > > - devm_clk_prepare()/devm_clk_unprepare(); > > - devm_clk_prepare_enable()/devm_clk_disable_unprepare(). > > > > Reviewed-by: Guenter Roeck > > Signed-off-by: Dmitry Torokhov > > It would be awesome if we could get it into 4.11... I'd prefer we didn't do this. Instead, make clk_put() drop any prepare or enables that were done via that clk pointer. Mike started to do this before[1], but we have some code that assumes it can do: clk = clk_get(...) clk_prepare_enable(clk) clk_put(clk) and have the clk stay on. Those would need to be changed. We would also need Russell's approval to update the clk_put() documentation to describe this change in behavior. [1] http://lkml.kernel.org/r/1438974570-20812-1-git-send-email-mturquette@baylibre.com -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project