From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751392AbdBNXVc (ORCPT ); Tue, 14 Feb 2017 18:21:32 -0500 Received: from erebus.the-tk.com ([109.74.205.187]:58272 "EHLO erebus.the-tk.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751023AbdBNXV3 (ORCPT ); Tue, 14 Feb 2017 18:21:29 -0500 X-Greylist: delayed 397 seconds by postgrey-1.27 at vger.kernel.org; Tue, 14 Feb 2017 18:21:24 EST DomainKey-Signature: a=rsa-sha1; c=nofws; d=the-tk.com; h=from:to:cc :subject:date:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; q=dns; s=sel0; b=dr2GR7 dtwk0iRIqX4xTL+ejBUqBK9SHDs5awPuxwV+iI29TN6zV0sATeqj4QKOFQJ20sJr QAErEZp1OhaQQ40RnfLWvJygwU4aF1huRodxKdu2EeayyPhZNEKzEYkIopJ/5P6N YIA6Q62QVmvuxA5/XWGdTrLvA3k0SprazLRJw= From: Tomasz Kramkowski To: Jiri Kosina Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Valtteri=20Heikkil=C3=A4?= , Tomasz Kramkowski Subject: [PATCH v2 1/2] HID: reject input outside logical range only if null state is set Date: Tue, 14 Feb 2017 23:14:32 +0000 Message-Id: <20170214231433.27060-2-tk@the-tk.com> X-Mailer: git-send-email 2.11.1 In-Reply-To: <20170214231433.27060-1-tk@the-tk.com> References: <20170214231433.27060-1-tk@the-tk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Valtteri Heikkilä This patch fixes an issue in drivers/hid/hid-input.c where USB HID control null state flag is not checked upon rejecting inputs outside logical minimum-maximum range. The check should be made according to USB HID specification 1.11, section 6.2.2.5, p.31. The fix will resolve issues with some game controllers, such as: https://bugzilla.kernel.org/show_bug.cgi?id=68621 [tk@the-tk.com: shortened and fixed spelling in commit message] Signed-off-by: Valtteri Heikkilä Signed-off-by: Tomasz Kramkowski --- drivers/hid/hid-input.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c index d05f903c7614..cf8256aac2bd 100644 --- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1157,6 +1157,7 @@ void hidinput_hid_event(struct hid_device *hid, struct hid_field *field, struct * don't specify logical min and max. */ if ((field->flags & HID_MAIN_ITEM_VARIABLE) && + (field->flags & HID_MAIN_ITEM_NULL_STATE) && (field->logical_minimum < field->logical_maximum) && (value < field->logical_minimum || value > field->logical_maximum)) { -- 2.11.0