From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752266AbdBORWS (ORCPT ); Wed, 15 Feb 2017 12:22:18 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:35430 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751904AbdBORWQ (ORCPT ); Wed, 15 Feb 2017 12:22:16 -0500 Date: Wed, 15 Feb 2017 12:22:15 -0500 (EST) Message-Id: <20170215.122215.823469813998299884.davem@davemloft.net> To: dmitry.torokhov@gmail.com Cc: richardcochran@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] PTP attribute handling cleanup From: David Miller In-Reply-To: <20170214182334.23296-1-dmitry.torokhov@gmail.com> References: <20170214182334.23296-1-dmitry.torokhov@gmail.com> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 15 Feb 2017 08:23:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dmitry Torokhov Date: Tue, 14 Feb 2017 10:23:30 -0800 > PTP core was creating some attributes, such as "period" and "fifo", and the > entire "pins" attribute group, after creating class deevice, which creates > a race for userspace: uevent may arrive before all attributes are created. > > This series of patches switches PTP to use is_visible() to control > visibility of attributes in a group, and device_create_with_groups() to > ensure that attributes are created before we notify userspace of a new > device. Richard, please review.