From: Minchan Kim <minchan@kernel.org>
To: Yisheng Xie <xieyisheng1@huawei.com>
Cc: <akpm@linux-foundation.org>, <ngupta@vflare.org>,
<sergey.senozhatsky.work@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <guohanjun@huawei.com>
Subject: Re: [RFC] mm/zsmalloc: remove redundant SetPagePrivate2 in create_page_chain
Date: Wed, 15 Feb 2017 16:13:44 +0900 [thread overview]
Message-ID: <20170215071344.GA23887@bbox> (raw)
In-Reply-To: <1487076509-49270-1-git-send-email-xieyisheng1@huawei.com>
On Tue, Feb 14, 2017 at 08:48:29PM +0800, Yisheng Xie wrote:
> We had used page->lru to link the component pages (except the first
> page) of a zspage, and used INIT_LIST_HEAD(&page->lru) to init it.
> Therefore, to get the last page's next page, which is NULL, we had to
> use page flag PG_Private_2 to identify it.
>
> But now, we use page->freelist to link all of the pages in zspage and
> init the page->freelist as NULL for last page, so no need to use
> PG_Private_2 anymore.
>
> This patch is to remove redundant SetPagePrivate2 in create_page_chain
> and ClearPagePrivate2 in reset_page(). Maybe can save few cycles for
> migration of zsmalloc page :)
>
> Signed-off-by: Yisheng Xie <xieyisheng1@huawei.com>
Acked-by: Minchan Kim <minchan@kernel.org>
Thanks, Yisheng!
prev parent reply other threads:[~2017-02-15 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 12:48 [RFC] mm/zsmalloc: remove redundant SetPagePrivate2 in create_page_chain Yisheng Xie
2017-02-14 16:16 ` Sergey Senozhatsky
2017-02-15 7:13 ` Minchan Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215071344.GA23887@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=guohanjun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ngupta@vflare.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=xieyisheng1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).