linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maksymilian Piechota <maksymilianpiechota@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Maksymilian Piechota <maksymilianpiechota@gmail.com>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line
Date: Wed, 15 Feb 2017 06:53:43 -0500	[thread overview]
Message-ID: <20170215115342.GA70990@maks-debian.localdomain> (raw)
In-Reply-To: <20170214171631.GA1518@kroah.com>

On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote:
> On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote:
> > move logical continuations at the end of line
> > 
> > Signed-off-by: Maksymilian Piechota <maksymilianpiechota@gmail.com>
> > ---
> >  drivers/staging/wlan-ng/prism2mgmt.c | 5 ++---
> >  1 file changed, 2 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c
> > index 16fb2d3..64a9ebc 100644
> > --- a/drivers/staging/wlan-ng/prism2mgmt.c
> > +++ b/drivers/staging/wlan-ng/prism2mgmt.c
> > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp)
> >  			hw->sniffhdr = 0;
> >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> >  		} else
> > -		    if ((msg->wlanheader.status ==
> > -			 P80211ENUM_msgitem_status_data_ok)
> > -			&& (msg->wlanheader.data == P80211ENUM_truth_true)) {
> > +		    if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && 
> > +			(msg->wlanheader.data == P80211ENUM_truth_true)) {
> >  			hw->sniffhdr = 1;
> >  			wlandev->netdev->type = ARPHRD_IEEE80211_PRISM;
> >  		} else {
> 
> This patch has checkpatch.pl errors.  Please always use checkpatch so
> you don't get emails from grumpy maintainers telling you to fix the
> checkpatch errors :)
> 
> Please fix up and resend the whole series.
> 
> thanks,
> 
> greg k-h

of course it has. Few patches ago I've sent all changes in one patch so
there was no errors. Then You asked me to break up every change to particular
commits, so there are checkpatch errors between them. PATCH 3/3 solves
all errors.

So how should I commit this changes, finally? I feel bit lost.

  reply	other threads:[~2017-02-15 11:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 14:21 [PATCHv6 0/3] staging: wlan-ng: align else if statement to coding standard Maksymilian Piechota
2017-02-13 14:25 ` [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line Maksymilian Piechota
2017-02-14 17:16   ` Greg Kroah-Hartman
2017-02-15 11:53     ` Maksymilian Piechota [this message]
2017-02-15 14:26       ` Greg Kroah-Hartman
2017-02-13 14:30 ` [PATCHv6 2/3] staging: wlan-ng: move else if statement to a single line Maksymilian Piechota
2017-02-13 14:32 ` [PATCHv6 3/3] staging: wlan-ng: realign else if continuation Maksymilian Piechota

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170215115342.GA70990@maks-debian.localdomain \
    --to=maksymilianpiechota@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).