From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751197AbdBONyi (ORCPT ); Wed, 15 Feb 2017 08:54:38 -0500 Received: from mail-dm3nam03on0080.outbound.protection.outlook.com ([104.47.41.80]:9520 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750781AbdBONyg (ORCPT ); Wed, 15 Feb 2017 08:54:36 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jan.Glauber@cavium.com; Date: Wed, 15 Feb 2017 14:54:23 +0100 From: Jan Glauber To: Arnd Bergmann Cc: Ulf Hansson , "kbuild-all@01.org" , "linux-mmc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , David Daney , "Steven J . Hill" , David Daney Subject: Re: [PATCH v11 6/9] mmc: cavium: Add MMC PCI driver for ThunderX SOCs Message-ID: <20170215135423.GA3464@hardcore> References: <20170206133953.8390-7-jglauber@cavium.com> <201702120922.DE85ulq1%fengguang.wu@intel.com> <20170213152408.GB27339@hardcore> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [88.66.107.110] X-ClientProxiedBy: DB5PR06CA0030.eurprd06.prod.outlook.com (10.162.165.40) To SN2PR07MB2589.namprd07.prod.outlook.com (10.167.15.19) X-MS-Office365-Filtering-Correlation-Id: cbd426e4-5613-4483-23f1-08d455aa2bc3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;3:MBIQuB7HQmU4/BgPXmkuv8EJusQRuBOTj2JbBv+IKLVX+sNegxNpoW/u0YFPQI8hsCUF8mW/UC5Jwnczxuc+zxeZ55frbV7eOqurfcnhSgkVFtyE/QA5Uiiv0a5KT2KxSL/KCDjH4z4Lmqmjfj/2sixSAto2F/JOJ5RSjQKfXH9IVaL+5sJfj1uSd+SdykH5wQfV76SZECBrMpUGNyM359Ic9DiqNkOMpA7zJN9pJjavLF11QwroLrYf69kbgpHuGy1O73tjPOmQjaAP1kUCjA==;25:g28JZEuX0XXNXro+Rj+IjXWPVsW3Od7df4mmsmcaAz7jEPuQW+2Iu/wb/q+GRZyk4pNSudM8h3PI+OzFWJqFDc2fiOm0dzA8YrJ1eHpN9+Xty/ICugqClFw3SbYbGBGXWQSy4HzE4tyWhjNgVAErnGWY/z+cDbwqldndWb9HpOUM/qPqD7hl73S4GBn+hVJmyaynrE7aXRtT3FgHQSADh3VgiF88h3iwSv5HN3PDMTB/WQbxT62ZWAYZIlykLmWNQSil4wYEqtmT0HTg3jJc3LTBhJJ+oNbtcHNezTxRP3Bj4KXaaazg6Udu0NVCjHFWbpu5udRqjfS6pzkYPWn6p50jq9qmVjNg6nmmtU6aD0uKEB9pCJ4xaE16ptfxLT+YJEkWHmxtcKQb/0Fmw3gRaZ3jqDSGlrFeB4yY5oK4y4cQT2Ig0IjJpTItBullEmOuQQY0K0vMrp61W8cj7zlqTg== X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;31:3vPJeqyTn9Zy3r4EqLjsKcHTajfo+LGZCrMl72jZARgkC1DuMNlY08bkbftyQYhCGh5fwXismndDvWcOx452sj8AAoNvr8ggbHB2Dz7NDIpaDxMQ4Y8EQGB/YUVN8NnyiaaHRLCybHVe24ALMsmSifEth9KqwxeCHHfgqYBeNS38Iu7+Vh4HVhUAYoErOPlVzJft2Fre230fehuy6yTpGiSOP8x8+5Q0rEv5X7kl4Rv8sHEYKBdj7BcrKc8XQhSp;20:ETIIWm6e97udsnD6gP2CtgOtkY3vdRFMFzS98b8k0+gcYeGE0Tj+R8nxN/x2SzalKFnXbJW0R1RCKy3EPFI59oSO9t+Z2ahzlfpjQH9/7uw8uzSwuLIssZ7VgXmpE4nwAgSXGSIkT59de/LHYECzT/BfeEDS/ajWsIVPWPUpa5Rz9qTfX0T6Of83o7FX6yQg8fpSYsrT/kGm6sbJuHdWDmEN27dLUntg8z9jHJgovEFbF1FypSpQoctnizBbmEHpKZ0x3cI341eSnU2PqdkxpcueK9ddnRVw6NUTi5hDKiScWNrb95R10mmzVK40mdhi/04vKFr6WBijVAaFfdiFojE7W1hvDz4yy0p0vkDVuOdqRjAr6+JC8XU5irM+1dw97gHQdKJu6yBsQSgUQbp4/o255tjoACV86pP9JQ3nbKTT2vk41BLwM7YC5jiRSAjtcOnZqtupWSj3RRJfj7jJoIcY1QbmPvS9ggxjEHz0CfBeGGg2/CVyr4nbwDQT9+5lkUwlIykScsOFWywXtG9R8L8jLyIX3jhwV6dZscC6sTBXsCMEj70OxUlkjlB2PCLW/OR0rMy5qnmso3bKPfItIvKlloNzo1ZFoAePIlwg45M= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(166708455590820)(84791874153150); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123560025)(20161123558025)(20161123555025)(20161123562025)(20161123564025)(6072148);SRVR:SN2PR07MB2589;BCL:0;PCL:0;RULEID:;SRVR:SN2PR07MB2589; X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;4:mSKa7wK0sTESjZQvYOD1XJhi5gwc+/Vx1U5CaEgl+Ki7ERgO1BfXBG1dD7Kd2cTOXzvgCkHgUPWG2fBR+rVVXzdr2zmuoBSLL0NYvHZdM5O7je/Ux6b42EiwuDLz3UE9fjKMG6FhvQeA9EZO53Odw9OeNRF5/EwjhVPfKUq8e24fdqWEjvxK6CeMAW2tlTxTBHWMwqBmd9fyuaeE9LgriWOJiafDdKzErKoiKxJidONW4LyGprL/gashV21tvrCZbVJvYrBwIHhILiKP2SEqJPIvpVN11uhwaBZchZU7ynEi9dU0Yf2tfToLbJqVyZ50Ueg40Vgjv9uxgke81slTG1tGhRr01HDRmNOprUXgup8OAv8PSUly/IaPRz+2rNurq+Yuvh6kjMp7pXgw3B0DPOk3/6sl9JGPrMtqFPAmr3o4zwEUt1EgzlyRdd+kbHhEVwjbrz0QyKm93tR1GtVYY7ksLEmtH2CL24WOpqxk4Uv4nu2WZoXWOk5l16qjh8/1yyNSCUemNQ8BbxF4/49GloBkRzp+vyIl+Lb/JsZvpA0Zs/LD0dmbUCD9Y+9ImAVv81z78nZxerwbzYEubCkiP1skyhvL5WVmmE5TqJfFdOHWqwfEQCWMtmewcPnNblxuQGFUO8R1ASCH7hDIUfwr4GO8yk/5Yk9OwJ9uAn5rvMFRUZGGz723IOQJ9Ao5hmEP X-Forefront-PRVS: 021975AE46 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(24454002)(377454003)(2950100002)(106356001)(42882006)(105586002)(6666003)(23726003)(53936002)(6916009)(1076002)(33656002)(8676002)(55016002)(50466002)(4326007)(9686003)(189998001)(53546003)(2906002)(6306002)(81166006)(6496005)(33716001)(6116002)(6246003)(4001350100001)(25786008)(83506001)(5890100001)(47776003)(81156014)(5660300001)(50986999)(54356999)(110136004)(7736002)(42186005)(76176999)(107886003)(38730400002)(3846002)(229853002)(97736004)(93886004)(66066001)(68736007)(92566002)(101416001)(305945005)(54906002)(389900002)(18370500001)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:SN2PR07MB2589;H:hardcore;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;SN2PR07MB2589;23:A0Fak6SOr1gdSHbEUJ75J9IjHZ52awzc3XvHgAfwA?= =?us-ascii?Q?rGj+Muzx6Z9ejo3YL7sl6Hpchksv8Yi4I78NdahMPUCq+EKPnnzdl5b0SClC?= =?us-ascii?Q?kU0qQHOGyPCtDdHMEQcIE/N40Mc3lYdwk9O86/SLE5Rtx/eJrBFarK5HTmFc?= =?us-ascii?Q?/HhDi3hpR19rL2OS5qM+kBL17GfeF2aVRDNs6THKTT7+SsJCim4iB98IFUuB?= =?us-ascii?Q?GNF0Lg1AHmWVkKnxKfLlz7gc3UxnEptf9XTr8Y9Lbf4tQv5V0XXDSSFz27qO?= =?us-ascii?Q?GVdjeJI3P6Se7KOhuCVQpNd8np5IfeWF4l2GjBrBdsH3iBYNjtFNHf4gVZh6?= =?us-ascii?Q?3Vq6iDEbNn+9aLL4fkXcf3oZlu9Qf4NCDaFj6vWdFPeFH9eHooEYEdP+GLZ6?= =?us-ascii?Q?DD6Ig6xXlKF0F5GRmLmrumCsRVkPsFfJjVOjhNtRs001CMsCxOkR2WlvL9py?= =?us-ascii?Q?PLIr/Lx2yLC3sKOS9DklRvJR2bdt9kGdUYYuGl54tMOs0mWRpMGQbiumhvTL?= =?us-ascii?Q?XP5KVQWqnYhpteLhhA54KmYQVnnfjStxBx75KqbsBZFD74msQI849RXn5Frm?= =?us-ascii?Q?JkbFvDeWkFDScmYedrut1zl0Z0bAg+Rr9C3XjRtmi4ZG0e1I90HLGfBh5/qd?= =?us-ascii?Q?pH2awiS96aqazjITIyE5IQr+Td4vXeriZr06CdPTm+JLH9i50qjlrezEOFVf?= =?us-ascii?Q?/PjirLpUlyOhl1IPe6z2emcJu7UB5uoOF3ZwAQGCGJaSeP4OFg6ELmERay+6?= =?us-ascii?Q?P6CV+X0DtKsTmP/n+WIjQ4uB6msWvgiZmmK2ldvl+pfYdI5Hi3fGDiqiw6Ga?= =?us-ascii?Q?ih0QjlMl7MwcA4UZRqg8+Ay1zFfY7pjNSCz5QOX+Xq2J1ZHmi9NgMqmqIKxn?= =?us-ascii?Q?mTpRj++fM2FDbd+LnQVnI3fWzYcnFRYtJTz3vt6Igi+puNAHshClOXBNIzCZ?= =?us-ascii?Q?KRyBhHiNQktM3TqY/SoLZ7/QlNEnkz4eFY8xkRZkn0ZLEyqI6PHGnIgNj7OM?= =?us-ascii?Q?VIGUFnUFNCBuaL6hHJ6mRf1jTSVT6HVshUXiRRw9ugmOjXaLp+eaxCRo9OMB?= =?us-ascii?Q?x4A8qovcEJJru3UZqcJyW2DmjhrylC+YoOad2ChnxUJzgxVSeKtJwYSrb1yY?= =?us-ascii?Q?ajJwHjVZ5a8S20n4+Q7iLkBA3JOnLqdyvcd/BBvresVlJDi/zxhNgccS3I5s?= =?us-ascii?Q?ginx8qWOceEG6rM51h00qDk/rEeSoQjMHNmNDcuW6R+iu6eLpVy+L6MAa8Xf?= =?us-ascii?Q?w8yEeeDZGCfUgXsWfLdHkZ9GMJp3lFynJ4BE9NxM+6OIMlo63E0HeaZ6Wv00?= =?us-ascii?Q?xnaOkueiBaNCxXUmcBNHj6z5UaAvFYOKfxo3Ner/dY/4UJqOabcjzCyTiWw0?= =?us-ascii?Q?SkfNbPFLqqEs7Wb3mY5RUpH6UDvgUqyRaJnb4Wob+EY8xnfClZQcBjPW5rxc?= =?us-ascii?Q?6RWoNlVtA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;6:Hj80YBq1GrGvH9BjsPjRiLZJuxnIf2k/Q00YKyJN1lr/eLB+PwrFPc7OiSyPMQJ8xVvCX14scP0Cj++bt1lU0vRNAi0fJFee2vX4czyl+JuK8krb2n3zMdSIwTZhNq8yOl4el9F7Sikv7O5cdeIdYAk4BFKHrlNROis+uW0eMfBT2kp+YRGDgS15d6bslpYGZNnY0MZHtV9GEBwgKTnHZg/6ZNrb6neb4qhgGBFsTg3nilQuz+snxsYwkuHeAX77uEdoF6DUve3pcCGQ5fDkywYZCXTMzsOn61M/Bff9BTh2sL4lDcc4XmWnz9P9I1tt74AgfIPFcoIbvTVXdTGWPdgMXqtbLtbv4LXlpjY19pzfIT2j399MgzuDOq5kMrCqBkUSdRd7twrCOgiKvZW4FQ==;5:vBXancM0J6nPZgIqW1+XwgsyD41zcRPi6ugdOfvt2nxCo+V5R+UKrdMBDA0ygPv/g3yLS9u64pc1ePtAdD/MuQZREmHcLI6t5XpqD3+D/PSmXA3DHqHF3WEKsaW3HFMy8NQBTR+QjP+7tsmH2EHenQ==;24:Nu+ChGto46BUWWRAUBQ3iMIW940gVzLuEPYOaRc26HG2ATqQ3aXJ1X9NzU0q03VeUHHmkLljIMdI8eeM8JW4MTmDAOz8AvJIaliuzO4fPdY= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN2PR07MB2589;7:7+YEo4v+/3LPxpzf+jjkmk5Wytx0X15fNKeUAUvKcquHFTzeEpq9RvuIAzt9SWFXknf9vSjpO5FI/Wa/D61Qs961jkc3pe+WUIcXiaIes5xThLHFi2GiTfF0a6X+XFKYulCcrasNqrnoxQZS8D/jw8QSrwTggu01063roiwA+s9P2qrPmyvw+YGRkyRlbguc3VexG3ZYzkMGetwSo4+OIAKvx/ypII7XHF0nvuwY6j3bHg2qTsEriH1AJHfMK4UDIxqgyDwsCBGsvYU6f4tzLFxdRjLIherNykN0QseHbVDm0+9IbZSXyi5dSr6X3OtPajMA7DqODq7APWxn9DfFJ5YiqVi57cot10jv0zjovjaKubDNcsDDfCaUgXNDJRUlXcRb9aWFWJRDB8oCEZ/IdjnHzSexiaCJTcjSx425ftrYEaERA/5TNdIx+hj/HRe+KBV8tzJWwXCOqWy3NPRo29EZxohTSbnQQEWfiLDK36t2WNlK4Hb9OQsCtDd9CShDaZuii/rGGLTjnzW3r0DMNQ== X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2017 13:54:31.5638 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN2PR07MB2589 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 01:34:40PM +0100, Arnd Bergmann wrote: > On Mon, Feb 13, 2017 at 4:45 PM, Ulf Hansson wrote: > > On 13 February 2017 at 16:24, Jan Glauber > > wrote: > >> On Sun, Feb 12, 2017 at 09:09:29AM +0800, kbuild test robot wrote: > >>> Hi Jan, > >>> > >>> [auto build test ERROR on linus/master] > >>> [also build test ERROR on v4.10-rc7 next-20170210] > >>> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > >>> > >>> url: https://github.com/0day-ci/linux/commits/Jan-Glauber/Cavium-MMC-driver/20170206-214740 > >>> config: arm64-allmodconfig (attached as .config) > >>> compiler: aarch64-linux-gnu-gcc (Debian 6.1.1-9) 6.1.1 20160705 > >>> reproduce: > >>> wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > >>> chmod +x ~/bin/make.cross > >>> # save the attached .config to linux build tree > >>> make.cross ARCH=arm64 > >>> > >>> All errors (new ones prefixed by >>): > >>> > >>> In file included from drivers/mmc/host/cavium-mmc.c:28:0: > >>> drivers/mmc/host/cavium-mmc.h:41:7: warning: "CONFIG_MMC_CAVIUM_THUNDERX" is not defined [-Wundef] > >>> #elif CONFIG_MMC_CAVIUM_THUNDERX > >>> ^~~~~~~~~~~~~~~~~~~~~~~~~~ > >> > >> Hi Ulf, > >> > >> We are aware of this build error, the line above should be: > >> #elif IS_ENABLED(CONFIG_MMC_CAVIUM_THUNDERX) > > > > Please avoid using IS_ENABLED() - unless really needed. > > > > Doesn't "#ifdef" work here? > > > > No, CONFIG_MMC_CAVIUM_THUNDERX is a tristate symbol and #ifdef won't > work for =m. Yes, that was the reason for using IS_ENABLED(). > Ideally, the base driver would not have any such preprocessor checks at > all though, and just work either way. While I realize that octeon and thunderx > are mutually exclusive in practice, the patch as it is written here is somewhat > confusing as turning on both options (with COMPILE_TEST) will break > at least one of the two. I'll try to get rid of the preprocessor checks for the next version. --Jan > Arnd