From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751486AbdBOO0y (ORCPT ); Wed, 15 Feb 2017 09:26:54 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:59316 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbdBOO0x (ORCPT ); Wed, 15 Feb 2017 09:26:53 -0500 Date: Wed, 15 Feb 2017 06:26:52 -0800 From: Greg Kroah-Hartman To: Maksymilian Piechota Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv6 1/3] staging: wlan-ng: move logical continuations at the end of line Message-ID: <20170215142652.GA11454@kroah.com> References: <8b7698a301c1e755ab8a0f1efe8414e8f792948e.1486993631.git.maksymilianpiechota@gmail.com> <20170214171631.GA1518@kroah.com> <20170215115342.GA70990@maks-debian.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170215115342.GA70990@maks-debian.localdomain> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 06:53:43AM -0500, Maksymilian Piechota wrote: > On Tue, Feb 14, 2017 at 09:16:31AM -0800, Greg Kroah-Hartman wrote: > > On Mon, Feb 13, 2017 at 09:25:49AM -0500, Maksymilian Piechota wrote: > > > move logical continuations at the end of line > > > > > > Signed-off-by: Maksymilian Piechota > > > --- > > > drivers/staging/wlan-ng/prism2mgmt.c | 5 ++--- > > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/staging/wlan-ng/prism2mgmt.c b/drivers/staging/wlan-ng/prism2mgmt.c > > > index 16fb2d3..64a9ebc 100644 > > > --- a/drivers/staging/wlan-ng/prism2mgmt.c > > > +++ b/drivers/staging/wlan-ng/prism2mgmt.c > > > @@ -1308,9 +1308,8 @@ int prism2mgmt_wlansniff(struct wlandevice *wlandev, void *msgp) > > > hw->sniffhdr = 0; > > > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > > > } else > > > - if ((msg->wlanheader.status == > > > - P80211ENUM_msgitem_status_data_ok) > > > - && (msg->wlanheader.data == P80211ENUM_truth_true)) { > > > + if ((msg->wlanheader.status == P80211ENUM_msgitem_status_data_ok) && > > > + (msg->wlanheader.data == P80211ENUM_truth_true)) { > > > hw->sniffhdr = 1; > > > wlandev->netdev->type = ARPHRD_IEEE80211_PRISM; > > > } else { > > > > This patch has checkpatch.pl errors. Please always use checkpatch so > > you don't get emails from grumpy maintainers telling you to fix the > > checkpatch errors :) > > > > Please fix up and resend the whole series. > > > > thanks, > > > > greg k-h > > of course it has. Few patches ago I've sent all changes in one patch so > there was no errors. Then You asked me to break up every change to particular > commits, so there are checkpatch errors between them. PATCH 3/3 solves > all errors. But you added NEW errors in this patch, which isn't ok at all. Don't make a new error and then remove it in a later one, that's just crazy! (hint, trailing whitespace...) Also, you made this change in a way that added another new problem (too long of a line), you don't have to do that in order to fix this one warning. Please fix up and resend. thanks, greg k-h