From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Leo Yan <leo.yan@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Wei Xu <xuwei5@hisilicon.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>
Subject: Re: [PATCH RFC 3/3] arm64: dts: register Hi6220's coresight debug module
Date: Wed, 15 Feb 2017 14:19:58 -0700 [thread overview]
Message-ID: <20170215211958.GC29730@linaro.org> (raw)
In-Reply-To: <1486966298-16767-4-git-send-email-leo.yan@linaro.org>
On Mon, Feb 13, 2017 at 02:11:38PM +0800, Leo Yan wrote:
> Bind coresight debug driver for Hi6220.
Bindings for the coresight debug driver...
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> ---
> .../boot/dts/hisilicon/hikey_6220_coresight.dtsi | 73 ++++++++++++++++++++++
> 1 file changed, 73 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hikey_6220_coresight.dtsi b/arch/arm64/boot/dts/hisilicon/hikey_6220_coresight.dtsi
> index 77c2aab..e14d75c 100644
> --- a/arch/arm64/boot/dts/hisilicon/hikey_6220_coresight.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hikey_6220_coresight.dtsi
> @@ -15,6 +15,79 @@
> #size-cells = <2>;
> compatible = "arm,amba-bus";
> ranges;
> +
> + debug@0,f6590000 {
Simply use "debug@f6590000", the "0," isn't required.
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf6590000 0 0x1000>;
> + default_enable;
What is the "default_enable" for ?
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu0>;
> + };
> +
> + debug@1,f6592000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf6592000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu1>;
> + };
> +
> + debug@2,f6594000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf6594000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu2>;
> + };
> +
> + debug@3,f6596000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf6596000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu3>;
> + };
> +
> + debug@4,f65d0000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf65d0000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu4>;
> + };
> +
> + debug@5,f65d2000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf65d2000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu5>;
> + };
> +
> + debug@6,f65d4000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf65d4000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu6>;
> + };
> +
> + debug@7,f65d6000 {
> + compatible = "arm,coresight-debug","arm,primecell";
> + reg = <0 0xf65d6000 0 0x1000>;
> + default_enable;
> + clocks = <&sys_ctrl HI6220_CS_ATB>;
> + clock-names = "apb_pclk";
> + cpu = <&cpu7>;
> + };
> +
> etm@0,f659c000 {
> compatible = "arm,coresight-etm4x","arm,primecell";
> reg = <0 0xf659c000 0 0x1000>;
> --
> 2.7.4
>
next prev parent reply other threads:[~2017-02-15 21:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-13 6:11 [PATCH RFC 0/3] coresight: enable debug module Leo Yan
2017-02-13 6:11 ` [PATCH RFC 1/3] coresight: binding for coresight debug driver Leo Yan
2017-02-15 11:13 ` Mark Rutland
2017-02-15 20:08 ` Mathieu Poirier
2017-02-16 13:55 ` Leo Yan
2017-02-13 6:11 ` [PATCH RFC 2/3] coresight: add support for debug module Leo Yan
2017-02-15 11:43 ` Mark Rutland
2017-02-16 18:14 ` Mathieu Poirier
2017-02-15 11:44 ` Mark Rutland
2017-02-16 15:21 ` Leo Yan
2017-02-15 21:08 ` Mathieu Poirier
2017-02-16 15:26 ` Leo Yan
2017-02-13 6:11 ` [PATCH RFC 3/3] arm64: dts: register Hi6220's coresight " Leo Yan
2017-02-15 21:19 ` Mathieu Poirier [this message]
[not found] ` <CAJ9a7VjiEwUEQVvuecYS9aLbe+4-eN-waEWirdv_ctsHPaXxWw@mail.gmail.com>
2017-02-13 23:37 ` [PATCH RFC 0/3] coresight: enable " Leo Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170215211958.GC29730@linaro.org \
--to=mathieu.poirier@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).