From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752641AbdBOWPg (ORCPT ); Wed, 15 Feb 2017 17:15:36 -0500 Received: from outbound-smtp03.blacknight.com ([81.17.249.16]:38154 "EHLO outbound-smtp03.blacknight.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751298AbdBOWPf (ORCPT ); Wed, 15 Feb 2017 17:15:35 -0500 Date: Wed, 15 Feb 2017 22:15:32 +0000 From: Mel Gorman To: Andrew Morton Cc: Shantanu Goel , Chris Mason , Johannes Weiner , Vlastimil Babka , LKML , Linux-MM Subject: Re: [PATCH 0/3] Reduce amount of time kswapd sleeps prematurely Message-ID: <20170215221532.o5rnx6wj6kfydyvv@techsingularity.net> References: <20170215092247.15989-1-mgorman@techsingularity.net> <20170215123055.b8041d7b6bdbcca9c5fd8dd9@linux-foundation.org> <20170215212906.3myab4545wa2f3yc@techsingularity.net> <20170215135654.315cbdca1c403c90a74f1bdd@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20170215135654.315cbdca1c403c90a74f1bdd@linux-foundation.org> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 15, 2017 at 01:56:54PM -0800, Andrew Morton wrote: > On Wed, 15 Feb 2017 21:29:06 +0000 Mel Gorman wrote: > > > On Wed, Feb 15, 2017 at 12:30:55PM -0800, Andrew Morton wrote: > > > On Wed, 15 Feb 2017 09:22:44 +0000 Mel Gorman wrote: > > > > > > > This patchset is based on mmots as of Feb 9th, 2016. The baseline is > > > > important as there are a number of kswapd-related fixes in that tree and > > > > a comparison against v4.10-rc7 would be almost meaningless as a result. > > > > > > It's very late to squeeze this into 4.10. We can make it 4.11 material > > > and perhaps tag it for backporting into 4.10.1? > > > > It would be important that Johannes's patches go along with then because > > I'm relied on Johannes' fixes to deal with pages being inappropriately > > written back from reclaim context when I was analysing the workload. > > I'm thinking specifically about these patches > > > > mm-vmscan-scan-dirty-pages-even-in-laptop-mode.patch > > mm-vmscan-kick-flushers-when-we-encounter-dirty-pages-on-the-lru.patch > > mm-vmscan-kick-flushers-when-we-encounter-dirty-pages-on-the-lru-fix.patch > > mm-vmscan-remove-old-flusher-wakeup-from-direct-reclaim-path.patch > > mm-vmscan-only-write-dirty-pages-that-the-scanner-has-seen-twice.patch > > mm-vmscan-move-dirty-pages-out-of-the-way-until-theyre-flushed.patch > > mm-vmscan-move-dirty-pages-out-of-the-way-until-theyre-flushed-fix.patch > > > > This is 4.11 material for sure but I would not automatically try merging > > them to 4.10 unless those patches were also included, ideally with a rerun > > of just those patches against 4.10 to make sure there are no surprises > > lurking in there. > > Head spinning a bit. You're saying that if the three patches in the > series "Reduce amount of time kswapd sleeps prematurely" are held off > until 4.11 then the above 6 patches from Johannes should also be held > off for 4.11? > Not quite, sorry for the confusion. Johannes's patches stand on their own and they are fine. I evaluated them before against 4.10-rcX and they worked as expected. If they go in first then these patches can go into 4.10-stable on top. If you plan to merge Johannes's patches for 4.10 or 4.10.1 then I have no problem with that whatsoever. -- Mel Gorman SUSE Labs