linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Petr Mladek <pmladek@suse.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org,
	"Rafael J. Wysocki" <rjw@rjwysocki.net>,
	linux-pm@vger.kernel.org, Russell King <rmk@armlinux.org.uk>
Subject: Re: Regression in next with use printk_safe buffers in printk
Date: Thu, 16 Feb 2017 13:25:00 +0900	[thread overview]
Message-ID: <20170216042500.GC772@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170216040335.GR21809@atomide.com>

On (02/15/17 20:03), Tony Lindgren wrote:
> * Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com> [170215 17:32]:
> > On (02/15/17 10:01), Tony Lindgren wrote:
> > [..]
> > > Below is another issue I noticed caused by commit f975237b7682 that
> > > I noticed during booting.
> > 
> > do you mean that with f975237b7682 you _always_ see that illegal RCU
> > usage warning?
> 
> Yeah on every boot on devices using cpuidle_coupled.

does this mean that with the printk-safe patches reverted
(so, basically, the same conditions module 4 printk patches)
you don't see illegal RCU usage reports? at the moment I can't
see any connection between f975237b7682 and RCU usage from idle CPU.

[..]

> > ---
> > 
> > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
> > index 7180088cbb23..34da86e73d00 100644
> > --- a/kernel/printk/printk.c
> > +++ b/kernel/printk/printk.c
> > @@ -1563,7 +1563,7 @@ static void call_console_drivers(const char *ext_text, size_t ext_len,
> >  {
> >  	struct console *con;
> >  
> > -	trace_console(text, len);
> > +	trace_console_rcuidle(text, len);
> >  
> >  	if (!console_drivers)
> >  		return;
> > 
> > ---
> > 
> > 
> > I need to look more at this.
> 
> That fixes it for me thanks, so feel free to add:
> 
> Tested-by: Tony Lindgren <tony@atomide.com>

thanks.

	-ss

  reply	other threads:[~2017-02-16  4:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-13 18:59 Regression in next with use printk_safe buffers in printk Tony Lindgren
2017-02-14 16:01 ` Sergey Senozhatsky
2017-02-14 16:18   ` Peter Zijlstra
2017-02-14 16:56     ` Sergey Senozhatsky
2017-02-14 17:03       ` Tony Lindgren
2017-02-15  4:44         ` Sergey Senozhatsky
2017-02-14 18:29       ` Peter Zijlstra
2017-02-15  4:49         ` Sergey Senozhatsky
2017-02-14 16:54   ` Tony Lindgren
2017-02-15 18:01   ` Tony Lindgren
2017-02-16  1:31     ` Sergey Senozhatsky
2017-02-16  4:03       ` Tony Lindgren
2017-02-16  4:25         ` Sergey Senozhatsky [this message]
2017-02-16 15:10           ` Tony Lindgren
2017-02-16 16:31             ` Sergey Senozhatsky
2017-02-16 19:13               ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170216042500.GC772@jagdpanzerIV.localdomain \
    --to=sergey.senozhatsky.work@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=pmladek@suse.com \
    --cc=rjw@rjwysocki.net \
    --cc=rmk@armlinux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).