From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932982AbdBQIl3 (ORCPT ); Fri, 17 Feb 2017 03:41:29 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:60938 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755650AbdBQIjJ (ORCPT ); Fri, 17 Feb 2017 03:39:09 -0500 Date: Thu, 16 Feb 2017 19:32:28 +0100 From: Maxime Ripard To: Rask Ingemann Lambertsen Cc: Chen-Yu Tsai , Mark Rutland , devicetree , Liam Girdwood , Rob Herring , linux-kernel , Mark Brown , Lee Jones , linux-arm-kernel Subject: Re: [PATCH v6 5/5] ARM: dts: sun9i: Initial support for the Sunchip CX-A99 board Message-ID: <20170216183228.3xgsy3idjgyw2boe@lukather> References: <20170210085920.7l7gswm6yjuqgdfx@lukather> <20170214233538.enkffjiw3kkfromu@localhost> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="psm2gqhv6ahsr7q7" Content-Disposition: inline In-Reply-To: <20170214233538.enkffjiw3kkfromu@localhost> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --psm2gqhv6ahsr7q7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Feb 15, 2017 at 12:35:39AM +0100, Rask Ingemann Lambertsen wrote: > On Fri, Feb 10, 2017 at 05:22:21PM +0800, Chen-Yu Tsai wrote: > > On Fri, Feb 10, 2017 at 4:59 PM, Maxime Ripard > > wrote: > > > Hi, > > > > > > On Thu, Feb 09, 2017 at 12:34:06AM +0100, Rask Ingemann Lambertsen wr= ote: > [...] > > >> diff --git a/arch/arm/boot/dts/sun9i-a80-cx-a99.dts b/arch/arm/boot/= dts/sun9i-a80-cx-a99.dts > > >> new file mode 100644 > > >> index 0000000..f5496d2 > > >> --- /dev/null > > >> +++ b/arch/arm/boot/dts/sun9i-a80-cx-a99.dts > [...] > > >> + pmic@745 { > > >> + compatible =3D "x-powers,axp808", "x-powers,axp806"; > >=20 > > As you mentioned elsewhere, they are not really compatible. > > You should drop the latter compatible. >=20 > The compatibility is good enough that it works fine with the driver that > went into kernel 4.9 and 4.10. Using this device tree file, I have built = and > booted 4.9.9 and 4.10-rc7 kernels as per the instructions here; > https://linux-sunxi.org/Sunchip_CX-A99#Linux_kernel > Likewise any other AXP806 driver which doesn't touch the register at addr= ess > 0xff will work fine. > > So, the disadvantage of removing the "x-powers,axp806" compatible is that > it breaks on two kernel versions where it works fine with the compatible. > What is the advantage of removing the "x-powers,axp806" compatible? This works fine for the features you tested, which are the regulators. All the other features of the PMIC are untested, and might or might not change, so you really don't know about the overall capability of the PMIC with another model. Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --psm2gqhv6ahsr7q7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYpfA7AAoJEBx+YmzsjxAgghAP/i81/yZnzUZbsEvsrlUbssiK ggZrcCQuTi1hhJivmjI9DUUAUhvIzphv///rGJQc+zb1KIbNk0OiWlL7ckIoO5IO Pcij8xY/hWNa1EPTE2WuY5x0uUmVArCWNKpWtInKlH5ZH2uNE9pF1I/sM5Oy2MQ2 cMq337UuX9h1AJe5zwnSZFHsEnyYii/JkzdKbzOPwK5dmE5nJL/Fol7CALlbBVYT nLsLKLrOwF+p51ysG/eOdZjvEKIOrVTTr0yo5yHf/ihST0BaxciGRIqb4zp2uUUL Tz+gYNxlTCrEmngXbRLVMP3TYtfSNV5xdeg4dWebwkIs80+nad9YXc43Ordyzs/v N8phsLFFIKzKvSxzNt3xJJ1qIR5FWWW8fQz+CC61iLcVjFwfPteC5f+rYtx+palL jy2QQSxP2dnz1EB5WT8LnwJAvdcBZEVVQlQ18W5wbgOm+WjLsDyaLpBZISaCxGFB 42KYloFyrFmRn9abokKG2SdNv3cEuzHtZ0a5MKfckZLcyfxFm9xk7BM+fWA58Du/ cHu9zPkswTfVOAavHq9lbi6ZSVVIMJBjISzm3c31cgYBh6KaRZfq7UBv3rIzDjde 6eBVQzOm9+q3cGl4AuoKkO0qobKoUTy17p3hlXE0m0ocuyfXIrsgykrtr+LVv0/N soZxw1k0ZJzLji/snw6s =PsMC -----END PGP SIGNATURE----- --psm2gqhv6ahsr7q7--