From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933705AbdBPWQs (ORCPT ); Thu, 16 Feb 2017 17:16:48 -0500 Received: from mail.kernel.org ([198.145.29.136]:60720 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933157AbdBPWQq (ORCPT ); Thu, 16 Feb 2017 17:16:46 -0500 Date: Thu, 16 Feb 2017 14:16:42 -0800 From: Shaohua Li To: Ming Lei Cc: Jens Axboe , linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , NeilBrown Subject: Re: [PATCH 00/17] md: cleanup on direct access to bvec table Message-ID: <20170216221642.sobqndndd7fbjoo7@kernel.org> References: <1487245547-24384-1-git-send-email-tom.leiming@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487245547-24384-1-git-send-email-tom.leiming@gmail.com> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 07:45:30PM +0800, Ming Lei wrote: > In MD's resync I/O path, there are lots of direct access to bio's > bvec table. This patchset kills most of them, and the conversion > is quite straightforward. I don't like this approach. The MD uses a hacky way to manage pages allocated, this is the root of the problem. The patches add another hack way to do the management. I'd like to see explict management of the pages, for example, add data structure in r1bio to manage the pages, then we can use existing API for all the stuffes we need. Thanks, Shaohua