From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933733AbdBPWTJ (ORCPT ); Thu, 16 Feb 2017 17:19:09 -0500 Received: from smtp-1b.atlantis.sk ([80.94.52.26]:57308 "EHLO smtp-1b.atlantis.sk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933698AbdBPWTH (ORCPT ); Thu, 16 Feb 2017 17:19:07 -0500 From: Ondrej Zary To: Finn Thain Subject: Re: g_NCR5380 PDMA, was Re: [PATCH 0/6] ncr5380: Miscellaneous minor patches Date: Thu, 16 Feb 2017 23:18:51 +0100 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: "James E.J. Bottomley" , "Martin K. Petersen" , Michael Schmitz , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <201701302252.13124.linux@rainbow-software.org> In-Reply-To: X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <201702162318.52483.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 31 January 2017 02:31:45 Finn Thain wrote: [...] > Are you trying to figure out which commands are going to disconnect during > a transfer? This is really a function of the firmware in the target; there > are no good heuristics AFAICT, so the PDMA algorithm has to be robust. > mac_scsi has to cope with this too. > > Does the problem go away when you assign no IRQ? When instance->irq == > NO_IRQ, the core driver will inhibit disconnect privileges. Yes, it seems to run fine with IRQ/disconnect disabled. With IRQ enabled, "dd if=/dev/sr0 of=anything" stops after a while. I get gated 53C80 IRQ, BASR=0x10, MODE=0x0e, STATUS=0x7c. When I enable interrupts during PDMA (like the removed UNSAFE macro did), the problems go away. I see an IRQ after each pread call. (had to disable "no 53C80 gated irq after transfer" and "no end dma signal" messages to reduce log spam) -- Ondrej Zary