From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754276AbdBQAfz (ORCPT ); Thu, 16 Feb 2017 19:35:55 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:43704 "EHLO mx0b-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751801AbdBQAfx (ORCPT ); Thu, 16 Feb 2017 19:35:53 -0500 Date: Thu, 16 Feb 2017 16:35:25 -0800 From: Shaohua Li To: Johannes Weiner CC: , , , , , , , , Subject: Re: [PATCH V3 2/7] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Message-ID: <20170217003524.GA95440@shli-mbp.local> References: <5c38c5f4d91e92ce86ee4f253e49c78708094632.1487100204.git.shli@fb.com> <20170216175253.GB20791@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170216175253.GB20791@cmpxchg.org> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [2620:10d:c090:200::8:f01f] X-ClientProxiedBy: MWHPR11CA0007.namprd11.prod.outlook.com (10.172.48.145) To MWHPR15MB1646.namprd15.prod.outlook.com (10.175.138.23) X-MS-Office365-Filtering-Correlation-Id: 1a3d8734-f81f-4292-340e-08d456cce207 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:MWHPR15MB1646; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;3:Ugv+7OEn6j2i7CFZJRmNKa6u09ZWZbn7aIwbzibcrw+uUItI7oIsAfGh/HfrOE+Wtyq4D2ANEKw6UrjRc4karxKN+kqvgF+yhNgiBJ87zRXYF89njUZHrwHYIQQ3QyvX0R1n6MCkm28xUz4Oho9sbXxIqJANK6gNTDOsd9YZysM2XsOO2ur5IbagY82kG+x9DSXy2pnzeo90I5euhLuZv01at8wS/3/uwdNkzMcwdmfBqj7FYqB5WNI0byjcPP50c2PG1VYgKnnWMsxFwA3IAA==;25:Mp6nE2alLQEURsrWFq03sBFAGIUyVzsa6rM1miwXFNsicIlkpGjVWBzVh/3IrEaRbtcLS5vspkRcyZ4m1yunT87HJ4FKm08+ors5bvkUelboWeZmyAC0WIeHejTuPtBRWpemuixmnOHSNNcYRX6LDoJUoh9vXQE1rtSACamDwV0f5hl6Gbe0ua+tQaFEqVkSRVFwina4R8dIqE1yegIo0dJ2Po2TV9vGrxHkgNyUdAR9otOs3bKSVeSuHQ8nKNInAmNeU8pNnLaphCGs7XUN2uL67rPGb0vOST7q4ybg/0ngNs6JysKezinSGkh/Kk/uOC1wBWqKY5+bosTZTgfIfYyB/duoMXl2RG53GIMxQHTdlvf5x/tn/V59VQagbxu+9C2EX5loLDC63Uthnod/8ZyaxwlSDE6usllyHERFFbH4+myIfxS22990JbY9Qii4Y8R8X0pgdSLgJt2VuzBfPw== X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;31:NAJFspq813Nz5RKTIyODXPVOuTcKWsmRkbj36BdyCgM2dJXPCBUB3I6LUFIBIceNVkSj4TnD8CPflHLggQMFiRK0eZM1JThPFYxXIDpTVuJ3GV7FTbBjT8PF80kC6V6dA4VZaIjo6+lLeb4gllYa/zOdCAbNWgGqd6BMoMTfDz4lEO/g+6gKpbggxR/AeAux4MihmAz1TYeB4ayoGzHi/xFT30qepse2C/mpE75vUDlGKlZ/OW1tC6kinNQAhfj9;20:7+P7u9gK2a8QNPZXc50OfYgEEB6rtUMt52W/hxKzfAmIqF7jNuXGFIchk/762/uOpGn9KKiQ5J+PZDIioXOuTVJBTyw/jke+EIPycUz8FfmhobSNWdYZlgHrGWEISyff2LNy9h3PDczm+b60K7jzHvGgkPdw2sQWfSBO0f6pQ7H6FtrWxGnP1yAR6MT4piK+kiSnXacrY0S3qenHYLRWw5YUXtRW8jSQj5HPUidSWy8ZVaQNtdlkytjfVapWncSQcyWvPMG6MBNv8FQTLjGF8H+iIVkdPw5Fj+EQZF5LJtTmOnrcdk+D+bqV5wASKFoNS1WPfGjTOxqXEXXBOMSpJmcEv9RVd80UopBHm3h59FXfcJ7dAzMnqXpwtilZJoX2e3gErTy8YXUmOUX6mLuE++faL9Xo2X1uq7nR+o8jlFhRjGQYmKak03skvYv+XPcAKtgI9xuYdZZlboYUX0PYx6NR17tSMP6SFTucU6oUP1n66G5mRFaRvkPmhtvHiK9T X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(20161123558025)(6072148);SRVR:MWHPR15MB1646;BCL:0;PCL:0;RULEID:;SRVR:MWHPR15MB1646; X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;4:YdMBmUeLxwxQFLtLIlGT/VVNz73e8UxN79wNfB9wIneNM08Xdjy5L319pjWTKZfnM3AIQg5BxSoW2a5nEPBEgZ9CbR9crN7brGHrrSwblj3tA+5P9OusNyggWC8jzactPR7EoXdmYcdNbnCEVacDkN7RoTLhemovLXqkwYTFP7i++8y/Y5/joN1jz3v2pH7SvmunM69OaXZqpteqUBdEhbF467oqTVMZ2yWTd2jJkaAii0qqZosAIpgyEHJbPYaVraSt06EP4w4icGEyCsu6PsqwWa7eiWvOX2erl0gGL3uiikLvuwzeqrtG4AItT1JPclXug1acoDiEkrARdqcH4n6s4+Vx5ssQm482Sfc5YZpx9HErzAiuEWCZrUnTPEcl4Z18bln8SMCEV3ygeuDenBWc6vRw6gfI0wEB79t7sXdaiWlk6idXxxxssnDIyTjmouFKB9OtbB+NjM0bVBqdSrd91gkxPYYBu6bqjHLqAbMr1RpwzHrz7LRcEJAqVorkR1A24jFVw8ZNsnnkEe6k4A0JUwz8n2GfF28/LDKkR7GJ9/OFMMYwKs02sIyAeWPY4HySTB9SPgmRWOfNZPz6trdMG6T8BOsFQY7R8ifaqaw= X-Forefront-PRVS: 02213C82F8 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39450400003)(39830400002)(39410400002)(189002)(24454002)(199003)(106356001)(33656002)(92566002)(81156014)(8676002)(110136004)(189998001)(4326007)(97756001)(97736004)(81166006)(1076002)(46406003)(55016002)(25786008)(4001350100001)(83506001)(6246003)(68736007)(54906002)(9686003)(305945005)(6506006)(98436002)(53936002)(105586002)(38730400002)(42186005)(229853002)(47776003)(50466002)(50986999)(76176999)(7736002)(101416001)(86362001)(2950100002)(5660300001)(2906002)(23726003)(6916009)(6666003)(6116002)(389900003)(54356999)(18370500001);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1646;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;MWHPR15MB1646;23:Uqzz2pnclEjqi41zBASSr0bymD28Qk3Zbi7ohXvx+?= =?us-ascii?Q?SZaoGiZbbek+olUwnv1e8ImB4cr6eGZBFAhasZCf5fQYWrvFxvQ5xIDSh5Kw?= =?us-ascii?Q?pCvQgRQDdwIpWnfrFwfSDRIuXUOZVrF8i6Q9fPxZMbRa1HzZFcWXf539NOFn?= =?us-ascii?Q?MbOwUF06vLwlbdMrjxg9Kn/MtqWtzM4TlJg4tLF4eoZI7/BbI5s6A3xGvtAZ?= =?us-ascii?Q?E7IYrxTL2+PBZ1eaolYTeMU4a1iZMuUQVtXXekxnnr1PKxyofg9oONZkhzzW?= =?us-ascii?Q?uegw9h0j5QMDDAZUtrCcsfqagy11zYavRfh1tebxexbNbeZNqpnvfBKCwblJ?= =?us-ascii?Q?7FKio90DNL3bmlweKpoUxFpgNWCF8EeNCBovlvhcU3+F1LhHqtbjI5UdwUTV?= =?us-ascii?Q?b1TqbPbzfA0kjF1lJvq4Rt23A4KTy6C3kaDnHzHRiLAokodZffqPq9WIVjsG?= =?us-ascii?Q?vGYTmNocUKibJUA0st+oPBF8B+AEUiXpJVXexKUPYar1rigsDSobXGS1gro2?= =?us-ascii?Q?Ohd9XKSDAG5gRFMiDvrYyjBwk16G6E087jIeFDt67cRWUNAtzEVuOjRfXOK4?= =?us-ascii?Q?wn6pMx0GF22fNK71PCTDPd6AYNq6cbk09ORG3evY/2UsBKX73+W8DFLohFJ9?= =?us-ascii?Q?JmpEK7RVP1pUAkHUjEUXkyS21s5J583wGUVrYKFhRAtcHw3Ke0tDAzwySpNo?= =?us-ascii?Q?G8KU/8qZ9ZQ+Wei0t6T/pSJmTkJGrP8cAl6Pv9wscaa4W+qRkaSMw9VtL+f1?= =?us-ascii?Q?q3cAdSfZmu1KQHq1/zPQSSonORBukXGc0orCd9M127j2T6vfeYfkeE6Nbp9e?= =?us-ascii?Q?Bc8AmUJ+c1PG9lfKuvFJbaA2cY9yBo7FbOU+A5Hj9oASad//Nlezq2KXhLQU?= =?us-ascii?Q?Y+mtfjLtkSk7p73drzXwudAfECyPSe7DwH0dkJ4YdzHr3HHBf980qrF2Bxk4?= =?us-ascii?Q?eErFgVnhs7udKsOciwy7kuk5QmeAT2i7wwvk1/mxs7hiOwi8+SWSPZa4i7YY?= =?us-ascii?Q?CMmAv6TbMSCO5J3drPJM48EG1CWA2weqWbG0Qq2gnBexuOSbtIdoJ9oc+tMx?= =?us-ascii?Q?7UuksXs3KlcDGwdQeaOz22277LJ6B97ioE1BNW8W7EySo2o3wWrd1aRtEl/r?= =?us-ascii?Q?U1qOUFrNqflS0bUN9b9c9c5dRxuoyPyOWqcrNLsIoiDsIF5mVebzyc9tr0AM?= =?us-ascii?Q?6UOEriT9pdjpHwFYUeLIR6OO0Y6D609cFFaYee+mgKr94vTlMFedWLMaZpPU?= =?us-ascii?Q?EVaevhTx32XjBbj7joXfKgBkB99z/Fw6x6YhIauFcjsRNJNJbYXNwkuEVPp+?= =?us-ascii?Q?B2NZsR34ODDpEiaZgSgzMwoZGB6fsBkJNUoZTlI4WRZ?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;6:eVVnewaVw65542Scrzt4ATcc/HtfJPBeCUidKMgy4co+2oLZm1jVlfh8OOZ/SuYePlw/862EAQWs3PIN3NcZz1rVXodO8Num/soaeVnbNAR1kLqlzVFiyHvTCI+b1JG7lhnjJAhywNRMfELwtjewdkflYqGwDte/Cet2BLI3lXJhypHzxB2YHQiyOCHmjh4NgE1jNJvlGTc+8jrVy/JtHDkoBr1xQM3HhFtWDSzikUn4ZLBNhe/Zr5J6NP+h7ZhYVc831PgVwUnwck1E8g3NTcceuY6LmZiTNqwS+ys3oq/g/HuQxAS1HN0L8WlXQ1eH4JxvYZg4RgVmZlqfeHh9iWrRDxqc72x6ly11Hww73qPIFF/iFT5b4znzdnEyUiHtYqqSRAAikLE4Y8MZj/hfmg==;5:cZm9DZuufrySndImjjDi6tcW01oVrB7uQnSeP66XA5zDdSyuYoJZ4XmY2do9EeBDFkyw+zkJKCaNu4/6OoxlSgSwndmF+fBzuk28TCWXdikkpJUHmyjvULwRCDmTNqBPPeHDxBU762jQxdBUt0PCqAhSIlAyv9IutrT1rR/HGAs=;24:LGdiT6z/G+1AQDtSZPqV0XWPm+tPds986Wvakv1nF/Aemjg+yabwR6A4pcTIbHwdSaslAxXIUG/IJh/wYfpQw1aVMEeMNKWg1UUGoUXiKgQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;MWHPR15MB1646;7:EIoIlrYJsa9k1AIH+K5qiLdY063VE5VQujecqHnQ6Zq48frXn9I7z0azWpNKdWu63UcG7LK6EC1INHx5HVPTg7DvK6L5KXZcuuzoDmMgs+8/xaIneiMPOvLAIdD9QcWEqLHeRsz1dkOo9do5n/gxo2ni702ZSnF/E/4thbe3rh2YVmoivueCcLyiDJT+oZAC2UAcR4bfrWFzbhE4mG0gED14Uomf4vB93hKZCzLUW21XfnAldEtjEo9VV6cmk6yAZD0VzC34dwUFOVJXyEmCMqlrYQ3FOLKG1U0Yu75vecrunepaIi6mnIl2QoWLMMjK/kiYbijHZSTiqRVSLB2HRQ==;20:+DkHJEDUSwl01sEKKDq1tIR0ICctuiwRyJydFGb2TzJXf+4Kbc8xOJ6KNUl8XWZZi6nyL61mKxiDpCEVFxvYLHAxVXLgi950EHJVaU6otohe/LIej3A8YsbcAfWwoeQF9S7VGhsYyIHq4LiUoBRr4Ii/oRI1xSslx8JK0Nvlqzw= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Feb 2017 00:35:32.5807 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1646 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-16_15:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 16, 2017 at 12:52:53PM -0500, Johannes Weiner wrote: > On Tue, Feb 14, 2017 at 11:36:08AM -0800, Shaohua Li wrote: > > @@ -126,4 +126,24 @@ static __always_inline enum lru_list page_lru(struct page *page) > > > > #define lru_to_page(head) (list_entry((head)->prev, struct page, lru)) > > > > +/* > > + * lazyfree pages are clean anonymous pages. They have SwapBacked flag cleared > > + * to destinguish normal anonymous pages. > > + */ > > +static inline void set_page_lazyfree(struct page *page) > > +{ > > + VM_BUG_ON_PAGE(!PageAnon(page) || !PageSwapBacked(page), page); > > + ClearPageSwapBacked(page); > > +} > > + > > +static inline void clear_page_lazyfree(struct page *page) > > +{ > > + VM_BUG_ON_PAGE(!PageAnon(page) || PageSwapBacked(page), page); > > + SetPageSwapBacked(page); > > +} > > + > > +static inline bool page_is_lazyfree(struct page *page) > > +{ > > + return PageAnon(page) && !PageSwapBacked(page); > > +} > > Sorry for not getting to v2 in time, but I have to say I strongly > agree with your first iterations and would much prefer this to be > open-coded. > > IMO this needlessly introduces a new state opaquely called "lazyfree", > when really that's just anonymous pages that don't need to be swapped > before reclaim - PageAnon && !PageSwapBacked. Very simple MM concept. > > That especially shows when we later combine it with page_is_file_cache > checks like the next patch does. > > The rest of the patch looks good to me. Thanks! I do agree checking PageSwapBacked is clearer, but Minchan convinced me because of the accounting issue. Where do you suggest we should put the accounting to? Thanks, Shaohua