From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751984AbdBSWj4 (ORCPT ); Sun, 19 Feb 2017 17:39:56 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:47815 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751668AbdBSWjy (ORCPT ); Sun, 19 Feb 2017 17:39:54 -0500 Date: Sun, 19 Feb 2017 23:39:49 +0100 From: Pavel Machek To: Andreas Kemnade Cc: "H. Nikolaus Schaller" , Mark Rutland , Andrey Gelman , Michel Verlaan , Nick Dyer , Tony Lindgren , linux-kernel@vger.kernel.org, Benjamin Tissoires , linux-omap@vger.kernel.org, Russell King , Aaro Koskinen , Javier Martinez Canillas , Igor Grinberg , Hans Verkuil , linux-input@vger.kernel.org, devicetree@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Arnd Bergmann , Eric Engestrom , Hans de Goede , Rob Herring , Mika =?iso-8859-1?Q?Penttil=E4?= , Mauro Carvalho Chehab , Petr Cvek , Siebren Vroegindeweij , Haibo Chen , Dmitry Torokhov , Sebastian Reichel , linux-iio@vger.kernel.org, "Andrew F. Davis" , Mark Brown , =?iso-8859-1?Q?Beno=EEt?= Cousson , kernel@pyra-handheld.com, Michael Welling , letux-kernel@openphoenux.org, Jonathan Cameron , Alexander Stein Subject: Re: [Letux-kernel] [PATCH v9 1/8] drivers:input:tsc2007: add new common binding names, pre-calibration, flipping and rotation Message-ID: <20170219223949.GA2470@amd> References: <20170218225435.GA4693@amd> <20170219141715.GA7159@amd> <05F3816F-46E6-4BC2-9E2E-F20E645F7197@goldelico.com> <20170219171518.GA12833@amd> <20170219190547.GA17292@amd> <20170219205708.GA9641@amd> <20170219232918.53801560@aktux> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q" Content-Disposition: inline In-Reply-To: <20170219232918.53801560@aktux> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Q68bSM7Ycu6FN28Q Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > > > And note that I am not making things different from others in tree, > > > I am making the tsc2007 right (incl. following the touchscreen > > > bindings which define the touchscreen size in "Pixels"). > >=20 > > Your touch screen is not in any way special, so it has to behave in > > the same way others do. > >=20 >=20 > I agree, the tsc2007 (=3Dwhat the interface provides to userspace) should > not behave special, for example it should behave like the virtual > touchscreen (=3Dwhat the interface provides to userspace) virtualbox > gives. No need to be calibrated. Well, the internals are different. But > that is what the kernel is good for, abstract such things. > Conclusion: It cannot be totally wrong behavior to have pixel values > there. It is not "totally wrong". But it is useless code that should not be in kernel. Calibration certainly does not belong to single _driver_. Feel free to submit driver but keep the calibration code out of tree... But if you have userspace that depends on touchscreen to be calibrated... that _is_ wrong. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --Q68bSM7Ycu6FN28Q Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAliqHrUACgkQMOfwapXb+vKmjgCgxGN0+2UP2ztzrW4TKK0NyeMN ufEAoImVS6jw6yD9lt/JsIf5RjRXfSa5 =OgiH -----END PGP SIGNATURE----- --Q68bSM7Ycu6FN28Q--