From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752001AbdBTJV7 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 20 Feb 2017 04:21:59 -0500
Received: from bombadil.infradead.org ([65.50.211.133]:39550 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751068AbdBTJV5 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 20 Feb 2017 04:21:57 -0500
Date: Mon, 20 Feb 2017 01:20:36 -0800
From: Christoph Hellwig <hch@infradead.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Al Viro <viro@ZenIV.linux.org.uk>, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] vfs: fix uninitialized flags in splice_to_pipe()
Message-ID: <20170220092036.GB5664@infradead.org>
References: <20170216164902.GC30656@veci.piliscsaba.szeredi.hu>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170216164902.GC30656@veci.piliscsaba.szeredi.hu>
User-Agent: Mutt/1.7.1 (2016-10-04)
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 16, 2017 at 05:49:02PM +0100, Miklos Szeredi wrote:
> From: Miklos Szeredi <mszeredi@redhat.com>
> 
> Flags (PIPE_BUF_FLAG_PACKET, PIPE_BUF_FLAG_GIFT) could remain on the unused
> part of the pipe ring buffer.  Previously splice_to_pipe() left the flags
> value alone, which could result in incorrect behavior.
> 
> Uninitialized flags appears to have been there from the introduction of the
> splice syscall.

Looks fine,

Reviewed-by: Christoph Hellwig <hch@lst.de>