From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752959AbdBTNJz (ORCPT ); Mon, 20 Feb 2017 08:09:55 -0500 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:58702 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752383AbdBTNJy (ORCPT ); Mon, 20 Feb 2017 08:09:54 -0500 Date: Mon, 20 Feb 2017 15:09:13 +0200 From: Sakari Ailus To: Pavel Machek Cc: sre@kernel.org, pali.rohar@gmail.com, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, ivo.g.dimitrov.75@gmail.com Subject: Re: [PATCH 1/4] v4l2: device_register_subdev_nodes: allow calling multiple times Message-ID: <20170220130912.GT16975@valkosipuli.retiisi.org.uk> References: <20170220103114.GA9800@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220103114.GA9800@amd> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Pavel, On Mon, Feb 20, 2017 at 11:31:14AM +0100, Pavel Machek wrote: > Hi! > > On Tue 2017-02-14 23:38:49, Pavel Machek wrote: > > From: Sebastian Reichel > > > > If v4l2_device_register_subdev_nodes() is called multiple times, it is > > better to return early than corrupt memory. > > > > Without this, exposure / gain controls do not work in the camera > > application on N900. > > > > Signed-off-by: Sebastian Reichel > > Signed-off-by: Ivaylo Dimitrov > > Signed-off-by: Pavel Machek > > Can I get some updates/feedback here? > > You liked this one and whole series should be ready... :-) I was just rebasing the CCP2 support on the fwnode patchset. I'm just pushing the result here: I've tested ACPI, will test DT soon... -- Kind regards, Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk