From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbdBTQjW (ORCPT ); Mon, 20 Feb 2017 11:39:22 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:59812 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752707AbdBTQjV (ORCPT ); Mon, 20 Feb 2017 11:39:21 -0500 Date: Mon, 20 Feb 2017 17:38:58 +0100 From: Alexandre Belloni To: Tony Lindgren Cc: Sebastian Reichel , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver Message-ID: <20170220163858.4ocqnfhei67wbtl3@piout.net> References: <20170220073535.27393-1-sre@kernel.org> <20170220073535.27393-2-sre@kernel.org> <20170220163155.GH21809@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220163155.GH21809@atomide.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20/02/2017 at 08:31:56 -0800, Tony Lindgren wrote: > * Sebastian Reichel [170219 23:37]: > > This driver supports the Motorola CPCAP PMIC found on > > some of Motorola's mobile phones, such as the Droid 4. > > Hey that's cool, works for me for reading and setting date :) > Just noticed one thing, see below. > > > +Requires node properties: > > +- compatible: should contain "motorola,cpcap-rtc" > > +- interrupts: An interrupt specifier for alarm and 1 Hz irq > > + > > +Example: > > + > > +cpcap_rtc: rtc { > > + compatible = "motorola,cpcap-rtc"; > > + interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>; > > +}; > > I tried rtcwake -s 3, but got the following: > > rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup: > No such file or directory > rtcwake: /dev/rtc0 not enabled for wakeup events > > Then tried adding "wakeup-source" to above but I think the driver > needs something, maybe probably just PM ops? > Probably device_init_wakeup(dev, 1) ? -- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com