From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754148AbdBTR1n (ORCPT ); Mon, 20 Feb 2017 12:27:43 -0500 Received: from muru.com ([72.249.23.125]:35962 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753355AbdBTR1l (ORCPT ); Mon, 20 Feb 2017 12:27:41 -0500 Date: Mon, 20 Feb 2017 09:27:37 -0800 From: Tony Lindgren To: Alexandre Belloni Cc: Sebastian Reichel , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver Message-ID: <20170220172737.GJ21809@atomide.com> References: <20170220073535.27393-1-sre@kernel.org> <20170220073535.27393-2-sre@kernel.org> <20170220163155.GH21809@atomide.com> <20170220163858.4ocqnfhei67wbtl3@piout.net> <20170220172103.GI21809@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170220172103.GI21809@atomide.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Tony Lindgren [170220 09:21]: > * Alexandre Belloni [170220 08:40]: > > On 20/02/2017 at 08:31:56 -0800, Tony Lindgren wrote: > > > * Sebastian Reichel [170219 23:37]: > > > > This driver supports the Motorola CPCAP PMIC found on > > > > some of Motorola's mobile phones, such as the Droid 4. > > > > > > Hey that's cool, works for me for reading and setting date :) > > > Just noticed one thing, see below. > > > > > > > +Requires node properties: > > > > +- compatible: should contain "motorola,cpcap-rtc" > > > > +- interrupts: An interrupt specifier for alarm and 1 Hz irq > > > > + > > > > +Example: > > > > + > > > > +cpcap_rtc: rtc { > > > > + compatible = "motorola,cpcap-rtc"; > > > > + interrupts = <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>; > > > > +}; > > > > > > I tried rtcwake -s 3, but got the following: > > > > > > rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup: > > > No such file or directory > > > rtcwake: /dev/rtc0 not enabled for wakeup events > > > > > > Then tried adding "wakeup-source" to above but I think the driver > > > needs something, maybe probably just PM ops? > > > > > > > Probably device_init_wakeup(dev, 1) ? > > That gets us a bit closer but now produces: > > rtcwake: write error Oh user error.. It needs to be done with: # rtcwake -s 3 -m mem And with the addition of device_init_wakeup(dev, 1) to the probe it works for me. So Sebastian, with that change, please feel free to add: Tested-by: Tony Lindgren