From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Valentin Huebner <valentin.huebner@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: board: Fix macro code style error
Date: Mon, 20 Feb 2017 18:55:06 +0100 [thread overview]
Message-ID: <20170220175506.GA30142@kroah.com> (raw)
In-Reply-To: <20170220174450.GA106887@ubuntu>
On Mon, Feb 20, 2017 at 05:44:50PM +0000, Valentin Huebner wrote:
> Fixes a 'macro with flow control statement' checkpatch code style
> error by removing the board_staging() macro and replacing its two
> calls
checkpatch is wrong here, you are now adding more lines than you remove:
> Signed-off-by: Valentin Hübner <valentin.huebner@gmail.com>
> ---
> drivers/staging/board/armadillo800eva.c | 10 +++++++++-
> drivers/staging/board/board.h | 11 -----------
> drivers/staging/board/kzm9d.c | 10 +++++++++-
> 3 files changed, 18 insertions(+), 13 deletions(-)
See?
There's nothing wrong with the macro as-is, it's like many other macros
we have for module init sequences. checkpatch is just a hint, you still
have to use your brain :)
sorry,
greg k-h
next prev parent reply other threads:[~2017-02-20 18:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-20 17:44 [PATCH] Staging: board: Fix macro code style error Valentin Huebner
2017-02-20 17:55 ` Greg Kroah-Hartman [this message]
2017-02-21 15:21 ` Valentin Hübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170220175506.GA30142@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=valentin.huebner@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).