From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751927AbdBTTfx (ORCPT ); Mon, 20 Feb 2017 14:35:53 -0500 Received: from mail.kernel.org ([198.145.29.136]:43424 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751100AbdBTTfw (ORCPT ); Mon, 20 Feb 2017 14:35:52 -0500 Date: Mon, 20 Feb 2017 20:35:42 +0100 From: Sebastian Reichel To: Tony Lindgren Cc: Alexandre Belloni , Alessandro Zummo , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/1] rtc: cpcap: new rtc driver Message-ID: <20170220193542.ey5cn46vusipmrv7@earth> References: <20170220073535.27393-1-sre@kernel.org> <20170220073535.27393-2-sre@kernel.org> <20170220163155.GH21809@atomide.com> <20170220163858.4ocqnfhei67wbtl3@piout.net> <20170220172103.GI21809@atomide.com> <20170220172737.GJ21809@atomide.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cd36rqh53rb7a4ar" Content-Disposition: inline In-Reply-To: <20170220172737.GJ21809@atomide.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --cd36rqh53rb7a4ar Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Feb 20, 2017 at 09:27:37AM -0800, Tony Lindgren wrote: > * Tony Lindgren [170220 09:21]: > > * Alexandre Belloni [170220 08:4= 0]: > > > On 20/02/2017 at 08:31:56 -0800, Tony Lindgren wrote: > > > > * Sebastian Reichel [170219 23:37]: > > > > > This driver supports the Motorola CPCAP PMIC found on > > > > > some of Motorola's mobile phones, such as the Droid 4. > > > >=20 > > > > Hey that's cool, works for me for reading and setting date :) > > > > Just noticed one thing, see below. > > > >=20 > > > > > +Requires node properties: > > > > > +- compatible: should contain "motorola,cpcap-rtc" > > > > > +- interrupts: An interrupt specifier for alarm and 1 Hz irq > > > > > + > > > > > +Example: > > > > > + > > > > > +cpcap_rtc: rtc { > > > > > + compatible =3D "motorola,cpcap-rtc"; > > > > > + interrupts =3D <39 IRQ_TYPE_NONE>, <26 IRQ_TYPE_NONE>; > > > > > +}; > > > >=20 > > > > I tried rtcwake -s 3, but got the following: > > > >=20 > > > > rtcwake: cannot open /sys/class/rtc/rtc0/device/power/wakeup: > > > > No such file or directory > > > > rtcwake: /dev/rtc0 not enabled for wakeup events > > > >=20 > > > > Then tried adding "wakeup-source" to above but I think the driver > > > > needs something, maybe probably just PM ops? > > > >=20 > > >=20 > > > Probably device_init_wakeup(dev, 1) ? > >=20 > > That gets us a bit closer but now produces: > >=20 > > rtcwake: write error >=20 > Oh user error.. It needs to be done with: >=20 > # rtcwake -s 3 -m mem >=20 > And with the addition of device_init_wakeup(dev, 1) to the probe > it works for me. So Sebastian, with that change, please feel free > to add: >=20 > Tested-by: Tony Lindgren Nice. I actually forgot to mention, that its missing wakeup support for now and now its already done :) I will resend later. -- Sebastian --cd36rqh53rb7a4ar Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAlirRQsACgkQ2O7X88g7 +pqedg/8DwDEBxV8ruyGsvuhWcZjrrKX+s4KV9PQL33G3A7YCpftwPHgBsSeyEK9 bKBdfpBcvHwwHwbSVBAln6ZFknKsxsc/RB6PT20kMOWnzC58R5PVCZRaZn4JYy/q yQrvKJ3xgPyuZACtsBJ9bhAy+AS54L+RPNU9sHy/Unwg7tMo/xjPsBBhzeRdirJx m4FiN9ENzVciOdrkzDuwtbMyI8roeHkHxXB2Qx2hR+zOy21+aZyEXeIwCg9ZJkML 6RxJYQvX4BQwOta5x3Rne9wD2toWu4C7JpeZbWIqL9cDROusHiKccJxfwjX0bog8 lMyxb0Pg3rlmeIEBkkdvM4AtYOjjPZcq5taIyKWSM8L6QRMdUSHa4MUMtGK9UjKA mDoNmGqyBPl1JQK7LTVX+wntzLPD7k+dgd7kW4EU6bP+Da915ka/GOEEMjH739x6 rzLdjT44hc4fHwKPD4F/cTAqtZ26l3u9PIghaqclNBWm/u8orfTk0cSKpO41M/NG 6H7vOXKx/LYRbgqYXWA27+gJ5STyxmSv9E56vTHA74lWkv1VFFv6aYp7dpeXz9+B QGprewVxXO11ydNAjflQRjG9OjZd32w4eApoG2jE10VqMDU4w6MwBVnFKhxW3xug QifoeQL/l/ZLKTqUUlFdoH9t00hQyIqhdj3wsFD+FEibmg8zNa8= =gaMO -----END PGP SIGNATURE----- --cd36rqh53rb7a4ar--