From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751268AbdBUIGd (ORCPT ); Tue, 21 Feb 2017 03:06:33 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46439 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbdBUIGb (ORCPT ); Tue, 21 Feb 2017 03:06:31 -0500 Date: Tue, 21 Feb 2017 09:06:10 +0100 From: Boris Brezillon To: Andy Shevchenko Cc: Richard Weinberger , "open list:MEMORY TECHNOLOGY..." , Nicolas Ferre , Alexandre Belloni , Haavard Skinnemoen , Hans-Christian Egtvedt , "linux-kernel@vger.kernel.org" , Wenyou Yang , Josh Wu , David Woodhouse , Brian Norris , Marek Vasut , Cyrille Pitchen , linux-arm Mailing List , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , devicetree Subject: Re: [PATCH v2 1/3] mtd: nand: Cleanup/rework the atmel_nand driver Message-ID: <20170221090610.6d531b94@bbrezillon> In-Reply-To: References: <1487593718-20752-1-git-send-email-boris.brezillon@free-electrons.com> <1487593718-20752-2-git-send-email-boris.brezillon@free-electrons.com> <20170220213803.7ba5591e@bbrezillon> <20170220215009.0ecbf5a1@bbrezillon> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 21 Feb 2017 01:54:37 +0200 Andy Shevchenko wrote: > On Tue, Feb 21, 2017 at 1:40 AM, Andy Shevchenko > wrote: > > On Mon, Feb 20, 2017 at 10:50 PM, Boris Brezillon > > wrote: > >> On Mon, 20 Feb 2017 21:38:03 +0100 > >> Boris Brezillon wrote: > >> > >>> On Mon, 20 Feb 2017 22:27:17 +0200 > >>> Andy Shevchenko wrote: > >>> > >>> > On Mon, Feb 20, 2017 at 2:28 PM, Boris Brezillon > >>> > wrote: > >>> > > >>> > > drivers/mtd/nand/atmel/nand-controller.c | 2269 +++++++++++++++++++++++++++ > >>> > > drivers/mtd/nand/atmel_nand.c | 2479 ------------------------------ > >>> > > >>> > Does -M -C help you? > >>> > At least it would help reviewers > >>> > > >>> > >>> No it doesn't, because files were not just moved around using git mv, > >>> it's a complete rewrite of the driver. IIUC, you're about to review > >>> this submission, or are you just trolling like last time? > >> > >> My bad, I mistaken you with someone else. Sorry for being harsh, but my > >> explanation stands ;-). > > > > No problem. I was asking since it so big and on first glance looks > > like a partial copy (I dunno if parameter to -C makes it somehow > > useful), though I can't review this. It's too big to me. Sorry I'm > > really not trolling, just didn't read commit message carefully. > > Okay, I very quickly looked into the code, what I noticed > - you like extra parens and empty lines in some cases (not big deal) Can you point specific places where you think these are not needed? > - some functions perhaps might have been refactored to have common > pieces in error handling, though I didn't read core carefully. Again, be more precise. > > Most important part I have noticed is a GPIO request. > I didn't get why you almost repeat gpiod_get() in case of platform data? > Shouldn't we have GPIO look up table? > Can we use builtin device properties (for GPIO and/or overall)? Sorry but I don't get it. Can give an example of what you'd like me to do? Thanks, Boris