From: Matthew Giassa <matthew@giassa.net>
To: Joe Perches <joe@perches.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
Wolfram Sang <wsa@the-dreams.de>,
Greg KH <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
driverdevel <devel@driverdev.osuosl.org>
Subject: Re: [PATCH] staging/ks7010: formatting updates.
Date: Tue, 21 Feb 2017 11:48:33 -0800 [thread overview]
Message-ID: <20170221194833.b34zc5iqxrydadrt@darkstar> (raw)
In-Reply-To: <1487702851.2853.25.camel@perches.com>
* Joe Perches <joe@perches.com> [2017-02-21 10:47:31 -0800]:
>On Tue, 2017-02-21 at 09:32 -0800, Matthew Giassa wrote:
>> * Geert Uytterhoeven <geert@linux-m68k.org> [2017-02-21 15:22:10 +0100]:
>>
>> > The first declaration fit nicely on a single line.
>> > The second one indeed has a few spaces instead of TABs in the
>> > continuation line. But that can be fixed easily, without moving the
>> > first parameter to a continuation line.
>>
>> What would the proposed fix be? A combination of spaces and hard-tabs? I
>> don't see checkpatch complaining about it, so that could work too.
>
>Maximal initial tabs, followed by required spaces to align
>to open parenthesis
>
Thank you Joe. I will change it accordingly. Is there a supplementary
style guide that covers these finer details?
Cheers!
--
-Matthew Giassa
e:<matthew@giassa.net>
next prev parent reply other threads:[~2017-02-21 19:48 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 4:20 [PATCH] staging/ks7010: formatting updates Matthew Giassa
2017-02-21 7:59 ` Geert Uytterhoeven
2017-02-21 14:12 ` Matthew Giassa
2017-02-21 14:22 ` Geert Uytterhoeven
2017-02-21 17:32 ` Matthew Giassa
2017-02-21 18:47 ` Joe Perches
2017-02-21 19:48 ` Matthew Giassa [this message]
2017-02-21 20:02 ` Joe Perches
2017-02-22 21:52 ` [PATCHv2] Checkpatch fixes for staging/drivers/ks7010 Matthew Giassa
2017-02-24 17:12 ` Greg KH
2017-02-27 2:00 ` [PATCHv3] checkpatch fixes for drivers/staging/ks7010/ks_wlan_ioctl.h Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 2/4] Removing trailing whitespace in comment block Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 3/4] Removing mixed spaces/hard-tabs in the alignment indentation to appease checkpatch Matthew Giassa
2017-02-27 2:00 ` [PATCHv3 4/4] Changing alignment and indentation in function prototypes so parameters line up to make checkpatch happy (no more warnings/errors) Matthew Giassa
2017-02-27 9:19 ` Sergei Shtylyov
2017-02-27 5:56 ` [PATCHv3 1/4] Encasing macros with complex values (ie: base value plus index) with parentheses Tobin C. Harding
2017-03-15 2:25 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa
2017-03-15 2:25 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa
2017-03-15 3:14 ` Tobin C. Harding
2017-03-15 20:27 ` Matthew Giassa
2017-03-16 2:42 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Greg KH
2017-03-16 3:18 ` [PATCHv5 0/4] Staging: ks7010: ks_wlan_ioctl.h: checkpatch fixes Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 1/4] Staging: ks7010: ks_wlan_ioctl.h: Removed mixed spaces/tabs Matthew Giassa
2017-03-17 6:22 ` Greg KH
2017-03-17 6:23 ` Greg KH
2017-03-16 3:18 ` [PATCHv5 2/4] Staging: ks7010: ks_wlan_ioctl.h: Remove trailing white space Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 3/4] Staging: ks7010: ks_wlan_ioctl.h: Aligning parameters in function prototypes Matthew Giassa
2017-03-16 3:18 ` [PATCHv5 4/4] Staging: ks7010: ks_wlan_ioctl.h: Wrap complex macros with parentheses Matthew Giassa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170221194833.b34zc5iqxrydadrt@darkstar \
--to=matthew@giassa.net \
--cc=devel@driverdev.osuosl.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).