From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933346AbdBVVKv (ORCPT ); Wed, 22 Feb 2017 16:10:51 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:43366 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755055AbdBVVKl (ORCPT ); Wed, 22 Feb 2017 16:10:41 -0500 Date: Wed, 22 Feb 2017 16:09:28 -0500 (EST) Message-Id: <20170222.160928.487250706697602435.davem@davemloft.net> To: ldv@altlinux.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] uapi: fix linux/if.h userspace compilation errors From: David Miller In-Reply-To: <20170221201914.GA28360@altlinux.org> References: <20170220115841.GA6846@altlinux.org> <20170221.121022.676021611021776681.davem@davemloft.net> <20170221201914.GA28360@altlinux.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 22 Feb 2017 12:10:35 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Dmitry V. Levin" Date: Tue, 21 Feb 2017 23:19:14 +0300 > On Tue, Feb 21, 2017 at 12:10:22PM -0500, David Miller wrote: >> From: "Dmitry V. Levin" >> Date: Mon, 20 Feb 2017 14:58:41 +0300 >> >> > Include (guarded by ifndef __KERNEL__) to fix >> > the following linux/if.h userspace compilation errors: >> >> Wouldn't it be so much better to do this in include/uapi/linux/socket.h? > > Yes, it would be nicer if we could afford it. However, changing > uapi/linux/socket.h to include is less conservative than > changing every uapi header that fails to compile because of its use > of struct sockaddr. It's risky because pulls in other > types that might conflict with definitions provided by uapi headers. Ok, I'll apply this for now.