From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753235AbdBVFEd (ORCPT ); Wed, 22 Feb 2017 00:04:33 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:54921 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750921AbdBVFEX (ORCPT ); Wed, 22 Feb 2017 00:04:23 -0500 X-Original-SENDERIP: 156.147.1.151 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Wed, 22 Feb 2017 14:04:15 +0900 From: Byungchul Park To: peterz@infradead.org, mingo@kernel.org Cc: ying.huang@intel.com, oleg@redhat.com, shli@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 8/9] sched: Don't reinvent the wheel but use existing llist API Message-ID: <20170222050415.GC3817@X58A-UD3R> References: <1487057190-25191-1-git-send-email-byungchul.park@lge.com> <1487057190-25191-9-git-send-email-byungchul.park@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487057190-25191-9-git-send-email-byungchul.park@lge.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 04:26:29PM +0900, Byungchul Park wrote: > Although llist provides proper APIs, they are not used. Make them used. Hello, What do you think? > > Signed-off-by: Byungchul Park > --- > kernel/sched/core.c | 15 +++------------ > 1 file changed, 3 insertions(+), 12 deletions(-) > > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index d01f9d0..8938125 100644 > --- a/kernel/sched/core.c > +++ b/kernel/sched/core.c > @@ -1773,7 +1773,7 @@ void sched_ttwu_pending(void) > { > struct rq *rq = this_rq(); > struct llist_node *llist = llist_del_all(&rq->wake_list); > - struct task_struct *p; > + struct task_struct *p, *t; > unsigned long flags; > struct rq_flags rf; > > @@ -1783,17 +1783,8 @@ void sched_ttwu_pending(void) > raw_spin_lock_irqsave(&rq->lock, flags); > rq_pin_lock(rq, &rf); > > - while (llist) { > - int wake_flags = 0; > - > - p = llist_entry(llist, struct task_struct, wake_entry); > - llist = llist_next(llist); > - > - if (p->sched_remote_wakeup) > - wake_flags = WF_MIGRATED; > - > - ttwu_do_activate(rq, p, wake_flags, &rf); > - } > + llist_for_each_entry_safe(p, t, llist, wake_entry) > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf); > > rq_unpin_lock(rq, &rf); > raw_spin_unlock_irqrestore(&rq->lock, flags); > -- > 1.9.1