From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753992AbdBVHKy (ORCPT ); Wed, 22 Feb 2017 02:10:54 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:39479 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbdBVHKq (ORCPT ); Wed, 22 Feb 2017 02:10:46 -0500 X-ME-Sender: X-Sasl-enc: q7VCDogVa0J5fUai5UYo22rS+UEM+vaLqeYCmLOj48A3 1487747445 Date: Wed, 22 Feb 2017 08:10:22 +0100 From: Greg KH To: Joakim Tjernlund Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/2] Correct function definition for C++ Message-ID: <20170222071022.GA9186@kroah.com> References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170221152405.7552-1-joakim.tjernlund@infinera.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > C++ does does not like the extra extern before asmlinkage, remove it. > > Signed-off-by: Joakim Tjernlund > --- > include/linux/printk.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/linux/printk.h b/include/linux/printk.h > index 3472cc6..be823f5 100644 > --- a/include/linux/printk.h > +++ b/include/linux/printk.h Why are you building this file with a C++ compiler? Also, this is not the correct way to submit patches for inclusion in the stable kernel tree. Please read Documentation/stable_kernel_rules.txt for how to do this properly. thanks, greg k-h