From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932298AbdBVNDs (ORCPT ); Wed, 22 Feb 2017 08:03:48 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51684 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754433AbdBVNDn (ORCPT ); Wed, 22 Feb 2017 08:03:43 -0500 X-ME-Sender: X-Sasl-enc: OOnb75SxErT/DQe6RImYo73+qHeaHe4AugegT5+kmwv5 1487768621 Date: Wed, 22 Feb 2017 14:03:18 +0100 From: "greg@kroah.com" To: Joakim Tjernlund Cc: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" Subject: Re: [PATCH 1/2] Correct function definition for C++ Message-ID: <20170222130318.GB15769@kroah.com> References: <20170221152405.7552-1-joakim.tjernlund@infinera.com> <20170222071022.GA9186@kroah.com> <1487749844.5760.17.camel@infinera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1487749844.5760.17.camel@infinera.com> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 22, 2017 at 07:50:46AM +0000, Joakim Tjernlund wrote: > On Wed, 2017-02-22 at 08:10 +0100, Greg KH wrote: > > On Tue, Feb 21, 2017 at 04:24:04PM +0100, Joakim Tjernlund wrote: > > > C++ does does not like the extra extern before asmlinkage, remove it. > > > > > > Signed-off-by: Joakim Tjernlund > > > --- > > > include/linux/printk.h | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/include/linux/printk.h b/include/linux/printk.h > > > index 3472cc6..be823f5 100644 > > > --- a/include/linux/printk.h > > > +++ b/include/linux/printk.h > > > > > > Why are you building this file with a C++ compiler? > > virtualbox uses C++ and includes various kernel headers and the build > fails, virtualbox guest additions has not build for quite some time now and > this is one of the problems. Virtualbox is a horrid pile of crap. You can quote me on that. We don't care about out-of-tree drivers, the authors should work to get them merged properly if they do care. Kernel code should be C, not C++, and if you do want to use C++, then you are on your own, sorry. > > Also, this is not the correct way to submit patches for inclusion in the > > stable kernel tree. Please read Documentation/stable_kernel_rules.txt > > for how to do this properly. > > Sorry, I was in a hurry(lazy:) so I just included stable directly as > I know it needs to be fixed in 4.9 as well. But that's not how to get a patch into the stable tree :( sorry, greg k-h