From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932821AbdBVOa1 (ORCPT <rfc822;w@1wt.eu>);
        Wed, 22 Feb 2017 09:30:27 -0500
Received: from mail-wr0-f195.google.com ([209.85.128.195]:32849 "EHLO
        mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932444AbdBVOaT (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 22 Feb 2017 09:30:19 -0500
Date: Wed, 22 Feb 2017 15:30:16 +0100
From: Frederic Weisbecker <fweisbec@gmail.com>
To: hejianet <hejianet@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, LKML <linux-kernel@vger.kernel.org>,
        Tony Luck <tony.luck@intel.com>, Wanpeng Li <wanpeng.li@hotmail.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Paul Mackerras <paulus@samba.org>, Fenghua Yu <fenghua.yu@intel.com>,
        Rik van Riel <riel@redhat.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [GIT PULL] cputime: Convert core use of cputime_t to nsecs
Message-ID: <20170222143014.GA2576@lerouge>
References: <1485751603-15913-1-git-send-email-fweisbec@gmail.com>
 <be6e8e48-0049-4ade-d0b0-3dd21d186999@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <be6e8e48-0049-4ade-d0b0-3dd21d186999@gmail.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Feb 21, 2017 at 01:08:24PM +0800, hejianet wrote:
> Hi Frederic
> 
> Do we need to support CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on ppc64le?
> 
> If yes, I got a compiling error after applying your patch set:
> 
> arch/powerpc/kernel/time.c:712:2: error: implicit declaration of function
> ‘cputime_to_nsecs’ [-Werror=implicit-function-declaration]
>   return local_clock() -
> cputime_to_nsecs(kcpustat_this_cpu->cpustat[CPUTIME_STEAL]);
>   ^
> 
> I thought it is due to CONFIG_VIRT_CPU_ACCOUNTING_NATIVE=n on my ppc64le server.
> My kernel config:
> # grep -n CONFIG_VIRT_CPU .config
> 136:CONFIG_VIRT_CPU_ACCOUNTING=y
> 137:CONFIG_VIRT_CPU_ACCOUNTING_GEN=y

Thanks for reporting! I posted a fix yesterday:

       "powerpc: Remove leftover cputime_to_nsecs call causing build error"
       https://lkml.org/lkml/2017/2/21/393