From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751198AbdBWN4b (ORCPT <rfc822;w@1wt.eu>);
        Thu, 23 Feb 2017 08:56:31 -0500
Received: from merlin.infradead.org ([205.233.59.134]:46284 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751034AbdBWN43 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 23 Feb 2017 08:56:29 -0500
Date: Thu, 23 Feb 2017 14:54:58 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Pavan Kondeti <pkondeti@codeaurora.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
        LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] sched: Optimize pick_next_task for idle_sched_class too
Message-ID: <20170223135458.GC6515@twins.programming.kicks-ass.net>
References: <20170119101703.2abeaeb6@gandalf.local.home>
 <20170119174408.GN6485@twins.programming.kicks-ass.net>
 <CAEU1=P=zZuYb-0W861Ek8wrqvZGfx1aVXC9_x4T8cyJptoPZWA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAEU1=P=zZuYb-0W861Ek8wrqvZGfx1aVXC9_x4T8cyJptoPZWA@mail.gmail.com>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 23, 2017 at 04:04:22PM +0530, Pavan Kondeti wrote:
> Hi Peter,
> 
> > diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> > index 49ce1cb..51ca21e 100644
> > --- a/kernel/sched/core.c
> > +++ b/kernel/sched/core.c
> > @@ -3321,15 +3321,14 @@ static inline void schedule_debug(struct task_struct *prev)
> >  static inline struct task_struct *
> >  pick_next_task(struct rq *rq, struct task_struct *prev, struct rq_flags *rf)
> >  {
> > -       const struct sched_class *class = &fair_sched_class;
> > +       const struct sched_class *class;
> >         struct task_struct *p;
> >
> >         /*
> >          * Optimization: we know that if all tasks are in
> >          * the fair class we can call that function directly:
> >          */
> > -       if (likely(prev->sched_class == class &&
> > -                  rq->nr_running == rq->cfs.h_nr_running)) {
> > +       if (likely(rq->nr_running == rq->cfs.h_nr_running)) {
> >                 p = fair_sched_class.pick_next_task(rq, prev, rf);
> >                 if (unlikely(p == RETRY_TASK))
> >                         goto again;
> 
> Would this delay pulling RT tasks from other CPUs? Lets say this CPU
> has 2 fair tasks and 1 RT task. The RT task is sleeping now. Earlier,
> we attempt to pull RT tasks from other CPUs in pick_next_task_rt(),
> which is not done anymore.

It should not; the two places of interrests are when we leave the RT
class to run anything lower (fair,idle), at which point we'll pull,
or when an RT tasks wakes up, at which point it'll push.