From: Tony Lindgren <tony@atomide.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] input: cpcap-pwrbutton: new driver
Date: Sat, 25 Feb 2017 11:21:00 -0800 [thread overview]
Message-ID: <20170225192100.GK21809@atomide.com> (raw)
In-Reply-To: <20170225185852.GB31929@dtor-ws>
* Dmitry Torokhov <dmitry.torokhov@gmail.com> [170225 11:00]:
> On Fri, Feb 24, 2017 at 09:59:09AM +0100, Sebastian Reichel wrote:
> > +#include <linux/mfd/motorola-cpcap.h>
> > +
> > +#define CPCAP_IRQ_ON 23
> > +#define CPCAP_IRQ_ON_BITMASK (1 << (CPCAP_IRQ_ON % 16))
>
> Is this truly static or it could depend= on IRQ returned by
> platform_get_irq()?
I suggest we add it to include/linux/mfd/motorola-cpcap.h:
static inline int cpcap_get_irq_status(struct device *dev,
struct regmap *regmap,
int irq,
u16 *status);
Or do you guys have better ideas?
I'll be needing that for the USB PHY driver too for multiple
bits so we want to return the whole bank register in status.
We may want to change to do that later to avoid dependencies
or set up an immutable branch with just that change.
Other than that things work for me based on a quick test.
Regards,
Tony
next prev parent reply other threads:[~2017-02-25 19:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-24 8:59 [PATCH] input: cpcap-pwrbutton: new driver Sebastian Reichel
2017-02-25 18:58 ` Dmitry Torokhov
2017-02-25 19:21 ` Tony Lindgren [this message]
2017-02-28 2:32 ` Tony Lindgren
2017-02-28 0:18 ` Rob Herring
2017-03-02 0:22 ` [PATCHv2 1/2] mfd: cpcap: implement irq sense helper Sebastian Reichel
2017-03-02 0:22 ` [PATCHv2 2/2] input: cpcap-pwrbutton: new driver Sebastian Reichel
2017-03-02 1:20 ` Dmitry Torokhov
2017-03-02 18:01 ` Tony Lindgren
2017-03-04 16:22 ` kbuild test robot
2017-03-02 15:17 ` [PATCHv2 1/2] mfd: cpcap: implement irq sense helper Tony Lindgren
2017-03-02 16:09 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170225192100.GK21809@atomide.com \
--to=tony@atomide.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).