From: Steven Rostedt <rostedt@goodmis.org>
To: Chunyu Hu <chuhu@redhat.com>
Cc: mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tracing: Fix code comment for ftrace_ops_get_func
Date: Mon, 27 Feb 2017 11:08:41 -0500 [thread overview]
Message-ID: <20170227110841.12fff548@gandalf.local.home> (raw)
In-Reply-To: <1487723366-14463-1-git-send-email-chuhu@redhat.com>
On Wed, 22 Feb 2017 08:29:26 +0800
Chunyu Hu <chuhu@redhat.com> wrote:
> There is no function 'ftrace_ops_recurs_func' existing in the code, it
> should be ftrace_ops_assist_func. Fix the comment to avoid misleading.
Applied, thanks!
I'm not sure it will go in this merge window. It might, I'll have to
see what else there is.
-- Steve
>
> Signed-off-by: Chunyu Hu <chuhu@redhat.com>
> ---
> kernel/trace/ftrace.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 0c06093..fd84f2e 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5487,7 +5487,7 @@ static void ftrace_ops_assist_func(unsigned long ip, unsigned long parent_ip,
> * Normally the mcount trampoline will call the ops->func, but there
> * are times that it should not. For example, if the ops does not
> * have its own recursion protection, then it should call the
> - * ftrace_ops_recurs_func() instead.
> + * ftrace_ops_assist_func() instead.
> *
> * Returns the function that the trampoline should call for @ops.
> */
prev parent reply other threads:[~2017-02-27 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-22 0:29 [PATCH] tracing: Fix code comment for ftrace_ops_get_func Chunyu Hu
2017-02-27 16:08 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227110841.12fff548@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=chuhu@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).