From: Steven Rostedt <rostedt@goodmis.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
Josh Triplett <josh@joshtriplett.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
David Miller <davem@davemloft.net>
Subject: Re: [PATCH] hlist_add_tail_rcu disable sparse warning
Date: Mon, 27 Feb 2017 13:40:36 -0500 [thread overview]
Message-ID: <20170227134036.2134852c@gandalf.local.home> (raw)
In-Reply-To: <1486748308-16653-1-git-send-email-mst@redhat.com>
On Fri, 10 Feb 2017 19:39:49 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> diff --git a/include/linux/rculist.h b/include/linux/rculist.h
> index 4f7a956..bf578e8 100644
> --- a/include/linux/rculist.h
> +++ b/include/linux/rculist.h
> @@ -509,7 +509,7 @@ static inline void hlist_add_tail_rcu(struct hlist_node *n,
> {
> struct hlist_node *i, *last = NULL;
>
> - for (i = hlist_first_rcu(h); i; i = hlist_next_rcu(i))
> + for (i = h->first; i; i = i->next)
Looks good to me, but I would probably add a comment above the loop
about this being in a write side section, and rcu conversions are not
needed.
Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
> last = i;
>
> if (last) {
prev parent reply other threads:[~2017-02-27 18:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 17:39 [PATCH] hlist_add_tail_rcu disable sparse warning Michael S. Tsirkin
2017-02-27 18:26 ` Michael S. Tsirkin
2017-04-26 13:13 ` Steven Rostedt
2017-04-26 14:02 ` Paul E. McKenney
2017-02-27 18:40 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170227134036.2134852c@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=davem@davemloft.net \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mst@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).