From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751465AbdB0QOI (ORCPT ); Mon, 27 Feb 2017 11:14:08 -0500 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:60680 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751291AbdB0QNz (ORCPT ); Mon, 27 Feb 2017 11:13:55 -0500 Date: Mon, 27 Feb 2017 08:13:10 -0800 From: Shaohua Li To: Minchan Kim CC: , , , , , , , , Subject: Re: [PATCH V5 3/6] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Message-ID: <20170227161309.GB62304@shli-mbp.local> References: <2f87063c1e9354677b7618c647abde77b07561e5.1487965799.git.shli@fb.com> <20170227062801.GB23612@bbox> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20170227062801.GB23612@bbox> User-Agent: Mutt/1.6.1 (2016-04-27) X-Originating-IP: [199.201.64.2] X-ClientProxiedBy: DM5PR2201CA0037.namprd22.prod.outlook.com (10.174.180.154) To BN6PR15MB1634.namprd15.prod.outlook.com (10.175.131.8) X-MS-Office365-Filtering-Correlation-Id: e3afd74c-7795-46d7-eb67-08d45f2b8c2b X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BN6PR15MB1634; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1634;3:JpIyddu6D/KHNypgLuo2sWUuBtpYCo5nQkBei3ENRDOpcSR/Zdr2UN/uyKocpCmt49foxA6yUZMHj7pr/X9mROxzDgVVYzKP3d9rWJmMmArPfKVbzIWWaVy4rWFAxST/L6q2uhiVldvmNnzVo5E1tHUDF2fhmBGUXo3XNVpm2xlZC+GFCK5+6O4UfjH1mxEjgJ974pqpcwSsqsRLuA66OQ8ZRBLQjpHuc+6kRwN+AIM7BGeaiMVWRxVse2ZhyhyXph4MsvoEa7S9BpfvTb2mjw==;25:lfzlVAN3sjZnILTw0W2dILs1D8RihlHNMVlsoTa1rTIgjNvMhCR93SvI1AQHz73G3eUngAk3M5CKFD4WShqp83JaWT6hx8dyVp2kSpszqyRYqhAQO0JSLSviw2dBpUR9mI8Twopj5AGb5IN2+uEzJsNehWr8M+FOe0mX+dcVb/JBeu64SCrfw2EgnJYd3lL+AeIskzfmv/SJPuC/QNTBZsFfB1wHgABP88JHiLCkSMJwtyMOeugdKKpU6dLD2030xP4YBL8EJEE3dFW60FJ9Ivb0uLxao+WzrusbIO9RQKFt+R/OTTaODCPE533x2XNZZkipuTEsxXTH/NECbRufu2fe6UG2izuZVeMgLGsTtlYbzvYB5E3c3vo1Xty9nPk6bX8BOpxKJZ/KCg4P2LOjOH2E8YekTJUBxsBX4bppY0Li9oHxPLfAI4BQU52azoeKGsNqd8a75kiDlFty7Nhhgg== X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1634;31:svP7dLI2mOSM11+o6gr5iNGuDws26aZrcwqK9vNzcdh/AeRutP6p9WeHt9Vu4H+uLXmUepauO8xhyrQrNk1SNZgzMp2uKVFCRmp7kXqBeCNzvtu+sOe3s2EBtfWnkwX2Sw4sWSJ71WydlYkusF8igMnpGuLpVOSmbwZR7tejmhc13t7u+dNuKjlAb5Lv6a6sHtj9Kfn39UMFFrxc+a1r8aoIVtIQ0GR2DWyTu1jpdRqQaRJDvBqIm+n5mBk3lLDw;20:gCKYzjp+KzdGsx2qTR5fKCcbG59ginJkNu/dt9XFYp7XQY6KWlxV99U5UYc/gdsIHcArNNvryZR0rQK7Rl3ujIuXQesgXn48cOL/DwTdkldZcifk1YmedrUI+xK2i47xEQ5J4nPFGyiO2j5lY54+dW6bKQO83mwak6A/8z4j/TmfF2ABfcHLz0qmpFHx5dIyBnLZ7Pa8shkIhbJxyOprFxvS4yUlltd9gCxHl8iG5C7BuByBKNAwg3V2y8QFoqt2lWFNvasJ0ZkS56uytEb0ddPqtUf0RkN7tdRHujTGSsL34GSeARTx4fl/dpivKL0WUA0HbXFqu/TySeBK0WTNqksWtu6iBxyP1YXBWxfRVSskY4zSXzN7jKmFlBcaHflKo05Sunly7VZTE4cPtNY96oIcBbAlEt3AHw6ecsTGjY3hftzSD2kp4J5wNWYPtfudYsFhthhkNAlcmRcFXCPnd2gHGhr0tVYEv4i2LfFReT8gdBUzg/M7P/KCEHm0KMXI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(67672495146484)(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041248)(20161123558025)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(6072148);SRVR:BN6PR15MB1634;BCL:0;PCL:0;RULEID:;SRVR:BN6PR15MB1634; X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1634;4:V0cwIkiOJYw28WXTig8mPJAmAbqPTVVb8LjHcsijpy6tozVYbXEI8k3REKA6T2L67mKNgAYi0funrxgoy13MlvzlK+XQqOJzelz7UYYy3p/DkTAGWnbPSOdstbfS1eSoUL64sXwJihF1p6FpIURzLtQTMSwPvq9paX460xq5LAA1B/DLa4U57qNjPUcb7ZzriL2Wk05T2tkRzrIGmZVVzo8um/jMZdnh9NtRynR2dRJnQxBo45AUtK20zidySouH5rbfbUgUYTdQCmaLtqdpnYkL4Cz2ofESGUajIHR37wOxTz4LiWgCjiM4iCw0fHD0S/tOsLxkbcmhDLTaPJG22EOwagD0Gfn3UBrmBP2KvTwIVrYXZ5TTTRDqzx5Y/JGBaEaX9fBoCO+BiBx2E8z4bJGae2BEVibjcNPBuILDNkCjThlWzXPPD4LB3sqsztSAX/O2ywnI0RR0/CnqOLeseD/4JJaEIjcMGHAd5hY5Fn8v0CXfsOf9WVOvP6udGJcGez2HGxSvJ+byME2EEmBMNLnJwLVHszexrAhUu//tmK4nX+b1Cv6D8RuTgrr1lXbBXZfbv1A3BqSG2wtWjII2dZth8Ioi0tw8fJDaHLnP74WoPtkzGcC6GPuKWQOnQTraiC8TjeG9BpsVqdPS9rwDPxw0V9HW3+U8qNMp5o2T/46/JQCB/0CsBkvwBVinOSGM X-Forefront-PRVS: 02318D10FB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6009001)(7916002)(39410400002)(39450400003)(39830400002)(24454002)(189002)(199003)(52314003)(6246003)(110136004)(229853002)(7736002)(38730400002)(101416001)(25786008)(76176999)(54356999)(50986999)(42186005)(23726003)(50466002)(66066001)(47776003)(106356001)(105586002)(54906002)(6506006)(86362001)(6666003)(6306002)(55016002)(46406003)(9686003)(5660300001)(97756001)(2950100002)(6916009)(92566002)(6116002)(3846002)(2906002)(189998001)(53936002)(83506001)(1076002)(81166006)(81156014)(4001350100001)(8676002)(68736007)(97736004)(33656002)(4326007)(305945005)(98436002)(18370500001)(6606295002);DIR:OUT;SFP:1102;SCL:1;SRVR:BN6PR15MB1634;H:shli-mbp.local;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN6PR15MB1634;23:8rP5DYqcnVjh7B2XrSOsACd36SLDAZZq/XxPDt0Cz?= =?us-ascii?Q?wGxvkVx9SSw8J8f8R4/r1F88bD652GBaT0rnbSffolnx9kLy6IA2/k6lmYY3?= =?us-ascii?Q?M3gJtnoyGuNKArjeDVf/izEhyUfhFupNKNXMrwYGHcKGi4W7Wfn4x7tMhjDw?= =?us-ascii?Q?BQdKweNjm8jg3zAB8NM7H5JIKe/Vv1/igu+KePXSrICJFM5sEOfc2nWastRU?= =?us-ascii?Q?TAmsIIV/Mu+XDC9+9h5rtY63PzneBKzNKAmmS8hqoNaQUktD8gPKowODsVVK?= =?us-ascii?Q?IAOed6uV+jvvRn0PkaYBPBpp5qVdik3RSzYX37AaDGFyW0uLnstJwGked8Pe?= =?us-ascii?Q?yCSlXCzHgYMzRm+RfjD2BxlKWIvbBUjKklweINwxYRK8kGdz8IXT3wUvlbnH?= =?us-ascii?Q?qO79FA3hnVxNCF7X0X2A/QvYmEU0SNKvtRQP4QjbuguW/1aAft/Bab5sOwYd?= =?us-ascii?Q?3K6Ci1bBBBnL1o/ppjIHuJgD5b87xsKKZ7bsPkEDvBCMpp5N0TCK8xt7mQtX?= =?us-ascii?Q?7IXhlF59YA7spk2tWc9tm4Ujo/yxo7qZ8FfsUhY1p0bcP8oAJuB832NvHsc1?= =?us-ascii?Q?T0M7K3gbIQHrDxNFV1GbKsFqtvJtuwYVOdAdexkmcU3iaCJu9caKBc4uSXAl?= =?us-ascii?Q?gYyL3PiqAVhmQYWGzX4Y+od2H9xnFkLx+OAydtf0eOx80U6kqD/IGZ4YM1wn?= =?us-ascii?Q?rIiP/mjUs9MdSRRPsGGmPOONG8qyCcfXuBEt0w8Q4GF7mfbtsjxE8AtCA7OX?= =?us-ascii?Q?cF4yPGX8g3m/b4nOQdM1kUKVkcN9VO16QUIr/JJi09aBGE3E8ZMoZ7UZ0NKa?= =?us-ascii?Q?ks/sMYBLdXw8AGZ7TJA+ELVwxdHKuGw7LK35wH7UoDT44lKLpAoGixImGS/o?= =?us-ascii?Q?9obJYdUUX/UiReLvQtxpUiVs6iP/TViLZugXleTaBDFYthWtTLUjGgNgkraE?= =?us-ascii?Q?j5M+P6YqR6xJHkNlBds1TpfKo9pC3s++uB8sV9Fqgo7SlKwhuRS2fj6pcuKO?= =?us-ascii?Q?A4HNeKwXo117R0dMaEBWwOFvshd0S/ac7Yome4rB41cTkpC3Qc9Ye4gKWgXQ?= =?us-ascii?Q?ZuYGWR8T/pcVvOo7uoFQG7tl4nn8dB1LsGpBM5FTJO5qqZTv+W7IgwTouji9?= =?us-ascii?Q?04S/5WOIP6HesXQvdD6nt1MH2x0PRLwFqgkrGoeoBt4q4ISZGiMU2dROf3wy?= =?us-ascii?Q?ONc2UYq7Ut3CueeetteriY1DHWMZaXdNcK2r2wuaeZSQMWNTnRcYwZ7OaRYy?= =?us-ascii?Q?iVWNmNNa77m9QYqe+hV25ZDn/no/dNGq5im+eOZKaKVtjG7eo/KZpjfxJ/Vs?= =?us-ascii?Q?CjmORq3zEFimefK8S1rqYRxVnKnGvtnLF6To6e2S1UwH6EfqktENGvauC9sq?= =?us-ascii?Q?W/Bt/y4hxFTnfN7LqVTUgD/97rMnlUvluoAPzBymQqRKZzmqovogAzvdQ1Mr?= =?us-ascii?Q?+fKXdMerw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1634;6:gJu+QrIXdne2g9iEb/lurF8fKclQsY9y4iCCas/iUfFVMwaN9Wwc+ApAIqODpf3KcQd8Gvu59oI9+Sn3oQ9OMycUzV2QB2k0Wk474Y63rWL/Aa42/GTyB0q7J1GPLK361wTXFCO1DEFthBPm+WJxreB3Djg5iQWGKa6KIAjVf9pUAxcv7ZO4CnpvIbnTAVqU0KhchxKdxy+hnaLY/Wvaoz3FJh+gUYCsHCTlw+Jjc/zI9dx7q54+HtQskyWorY31W3Vk2yHDlLTXWTe/I+1ys9AVqeAN+51o+JdDC5C3YlrLy/yW2s2NUJ30XNos0viN0WzQvXeVjCzAUNQ1WFb07xstGd9sRFPKzGBh+bsVV9n01Np+8kuWptJ1DX2zRPORjb+sqcHRel2i3+5vzafCNQ==;5:h3VVhjAK0FB9AfvPJgBgrCcwgLrj9mAWZHYQeaFyTucObcG8kBgEpg46xIIlqYbu+D6fEIuV1GrIjuyshQ7ebdTT2sUiMOARkF3jeVjryQfv9OOPvGP7mxuiEfipAvKoSNCNeTKgNxF9cAePpuu+eQ==;24:5uyQuPpdd0ZZGDrLDzRNxSsgUJMQ+/dSF/37a4pVMiP/+JVKMNnV5yxoYUQ4Io1qaURB071qpGMF6GWkqh1Nit/Rbfc69EuEBV+Srsiujeo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN6PR15MB1634;7:3icf4u1ino9UfevdQzf24ruX7LLB+das0cfaS7mls2e4b938mpNOpKMJU0VTqv0aUSPGsPCR5tpNWvDB+rhiUfv4yChf5pTT9a40T/KkhpjkZla2+mm10odknkCRGh4CWIBSeQTOrA7iRgGgQkMhifoLOM2hJcAgMFU5g9VlvmIFbdDntKB9B5RiN8gaX4JnWV7oAcKvloW8YxtRuI3qP2nbReKwCV+Sn6LiFgAJNdZDlHhrm+lNUMoICjBwg6VzqNgmlLYnHQsg1NrmbvL3OTSJqxJ3DQCkKiUzK3P/yusjBeDpXS92Cic7js5nhP+GaFpKbaw5SGSlaJrJouIBpA==;20:oTtQ8vMTQEtaxCuF22RQLXCCl0H+IjLXi/mVecjlbU9LXy+afxrdcoh7adNT6rY2YQUkUDYRRUBuT4URwe9irWo8pFPjKXPDDXwvXY61bMfE62lHy4xnSSQUJ/n2m08yaMAmyIlfBx5Mcir1sau/RV+qDVSFQRXK0h3VDa5JVB4= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Feb 2017 16:13:18.6016 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR15MB1634 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-27_11:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 27, 2017 at 03:28:01PM +0900, Minchan Kim wrote: > Hello Shaohua, > > On Fri, Feb 24, 2017 at 01:31:46PM -0800, Shaohua Li wrote: > > madv MADV_FREE indicate pages are 'lazyfree'. They are still anonymous > > pages, but they can be freed without pageout. To destinguish them > > against normal anonymous pages, we clear their SwapBacked flag. > > > > MADV_FREE pages could be freed without pageout, so they pretty much like > > used once file pages. For such pages, we'd like to reclaim them once > > there is memory pressure. Also it might be unfair reclaiming MADV_FREE > > pages always before used once file pages and we definitively want to > > reclaim the pages before other anonymous and file pages. > > > > To speed up MADV_FREE pages reclaim, we put the pages into > > LRU_INACTIVE_FILE list. The rationale is LRU_INACTIVE_FILE list is tiny > > nowadays and should be full of used once file pages. Reclaiming > > MADV_FREE pages will not have much interfere of anonymous and active > > file pages. And the inactive file pages and MADV_FREE pages will be > > reclaimed according to their age, so we don't reclaim too many MADV_FREE > > pages too. Putting the MADV_FREE pages into LRU_INACTIVE_FILE_LIST also > > means we can reclaim the pages without swap support. This idea is > > suggested by Johannes. > > > > This patch doesn't move MADV_FREE pages to LRU_INACTIVE_FILE list yet to > > avoid bisect failure, next patch will do it. > > > > The patch is based on Minchan's original patch. > > > > Cc: Michal Hocko > > Cc: Minchan Kim > > Cc: Hugh Dickins > > Cc: Rik van Riel > > Cc: Mel Gorman > > Cc: Andrew Morton > > Suggested-by: Johannes Weiner > > Signed-off-by: Shaohua Li > > This patch doesn't address I pointed out in v4. > > https://marc.info/?i=20170224233752.GB4635%40bbox > > Let's discuss it if you still are against. I really think a spearate patch makes the code clearer. There are a lot of places we introduce a function but don't use it immediately, if the way makes the code clearer. But anyway, I'll let Andrew decide if the two patches should be merged. Thanks, Shaohua