From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751542AbdB0QbA (ORCPT ); Mon, 27 Feb 2017 11:31:00 -0500 Received: from mx2.suse.de ([195.135.220.15]:52786 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdB0Qa4 (ORCPT ); Mon, 27 Feb 2017 11:30:56 -0500 Date: Mon, 27 Feb 2017 17:30:10 +0100 From: Michal Hocko To: Shaohua Li Cc: Minchan Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Kernel-team@fb.com, hughd@google.com, hannes@cmpxchg.org, riel@redhat.com, mgorman@techsingularity.net, akpm@linux-foundation.org Subject: Re: [PATCH V5 3/6] mm: move MADV_FREE pages into LRU_INACTIVE_FILE list Message-ID: <20170227163009.GM26504@dhcp22.suse.cz> References: <2f87063c1e9354677b7618c647abde77b07561e5.1487965799.git.shli@fb.com> <20170227062801.GB23612@bbox> <20170227161309.GB62304@shli-mbp.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170227161309.GB62304@shli-mbp.local> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 27-02-17 08:13:10, Shaohua Li wrote: > On Mon, Feb 27, 2017 at 03:28:01PM +0900, Minchan Kim wrote: [...] > > This patch doesn't address I pointed out in v4. > > > > https://marc.info/?i=20170224233752.GB4635%40bbox > > > > Let's discuss it if you still are against. > > I really think a spearate patch makes the code clearer. There are a lot of > places we introduce a function but don't use it immediately, if the way makes > the code clearer. But anyway, I'll let Andrew decide if the two patches should > be merged. I agree that it is almost always _preferable_ to add new functions along with their callers. In this particular case I would lean towards keeping the separation the way Shaohua did it because it makes the code really cleaner IMHO. -- Michal Hocko SUSE Labs