Re: [PATCH V2 2/3] Documentation: sprd: Add bindings for SP9860G

[Rob Herring <robh@kernel.org>]

On Tue, Feb 21, 2017 at 02:55:03PM +0800, Chunyan Zhang wrote:
> Added support for Spreadtrum SP9860G board and SC9860 SoC.
> This patch also revised bindings of SC9836 to make the format
> more clear.
> 
> Signed-off-by: Chunyan Zhang <chunyan.zhang@spreadtrum.com>
> ---
>  Documentation/devicetree/bindings/arm/sprd.txt         | 13 ++++++++-----
>  Documentation/devicetree/bindings/serial/sprd-uart.txt | 16 +++++++++++++++-

Probably should be 2 commits.

"dt-bindings: (arm|serial): " is the preferred subject prefix.

>  2 files changed, 23 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/sprd.txt b/Documentation/devicetree/bindings/arm/sprd.txt
> index 31a629d..3df034b 100644
> --- a/Documentation/devicetree/bindings/arm/sprd.txt
> +++ b/Documentation/devicetree/bindings/arm/sprd.txt
> @@ -1,11 +1,14 @@
>  Spreadtrum SoC Platforms Device Tree Bindings
>  ----------------------------------------------------
>  
> -Sharkl64 is a Spreadtrum's SoC Platform which is based
> -on ARM 64-bit processor.
> +SC9836 openphone Board
> +Required root node properties:
> +	- compatible = "sprd,sc9836-openphone", "sprd,sc9836";
>  
> -SC9836 openphone board with SC9836 SoC based on the
> -Sharkl64 Platform shall have the following properties.
> +SC9860 SoC
> +Required root node properties:
> +	- compatible = "sprd,sc9860"
>  
> +SP9860G 3GFHD Board
>  Required root node properties:
> -        - compatible = "sprd,sc9836-openphone", "sprd,sc9836";
> +	- compatible = "sprd,sp9860g-1h10", "sprd,sc9860";
> diff --git a/Documentation/devicetree/bindings/serial/sprd-uart.txt b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> index 2aff0f2..f530cbb 100644
> --- a/Documentation/devicetree/bindings/serial/sprd-uart.txt
> +++ b/Documentation/devicetree/bindings/serial/sprd-uart.txt
> @@ -1,7 +1,21 @@
>  * Spreadtrum serial UART
>  
>  Required properties:
> -- compatible: must be "sprd,sc9836-uart"
> +- compatible must contain:
> +  * "sprd,sc9836-uart" for SC9836 and all Spreadtrum SoCs
> +  This also can be specific with:
> +  * "sprd, sc9860-uart" for SC9860
space        ^

> +
>  - reg: offset and length of the register set for the device
>  - interrupts: exactly one interrupt specifier
>  - clocks: phandles to input clocks.
> +
> +Example:
> +	uart0: serial@70000000 {
> +		compatible = "sprd,sc9838-uart",
> +			     "sprd,sc9836-uart";
> +		reg = <0x000000 0x100>;
> +		interrupts = <GIC_SPI 2 IRQ_TYPE_LEVEL_HIGH>;
> +		clocks = <&ext_26m>;
> +		status = "disabled";

No need for status in examples.

> +	};
> -- 
> 2.7.4
>