From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752733AbdCAKiZ (ORCPT ); Wed, 1 Mar 2017 05:38:25 -0500 Received: from mail-wm0-f67.google.com ([74.125.82.67]:35427 "EHLO mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752288AbdCAKiJ (ORCPT ); Wed, 1 Mar 2017 05:38:09 -0500 Date: Wed, 1 Mar 2017 11:37:12 +0100 From: Ingo Molnar To: linux-kernel@vger.kernel.org, tglx@linutronix.de, jpoimboe@redhat.com, a.p.zijlstra@chello.nl, torvalds@linux-foundation.org, peterz@infradead.org, hpa@zytor.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:core/urgent] objtool: Fix __unreachable section relocation size Message-ID: <20170301103712.GA22478@gmail.com> References: <20170301060504.oltm3iws6fmubnom@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * tip-bot for Josh Poimboeuf wrote: > Commit-ID: 90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5 > Gitweb: http://git.kernel.org/tip/90a7e63a31b8f7d630d12ef0d8d37d3ab87f76e5 > Author: Josh Poimboeuf > AuthorDate: Wed, 1 Mar 2017 00:05:04 -0600 > Committer: Ingo Molnar > CommitDate: Wed, 1 Mar 2017 07:38:25 +0100 > > objtool: Fix __unreachable section relocation size > > Linus reported the following commit broke module loading on his laptop: > > d1091c7fa3d5 ("objtool: Improve detection of BUG() and other dead ends") > > It showed errors like the following: > > module: overflow in relocation type 10 val ffffffffc02afc81 > module: 'nvme' likely not compiled with -mcmodel=kernel BTW., beyond inadequate testing, another mistake I failed to notice during review is that the title of the patch was actively misleading: an "objtool: " prefix suggests a change that only affects objtool, while the changes here were to compiler-gcc.h, affecting pretty much everyone... So a better, more informative commit title would have been: objtool, compiler.h: Improve detection of BUG() and other dead ends ... to at least warn people about the wider impact. (To be honest I personally probably would still not have noticed the bug, but maybe others.) Along the same lines I'll fix the title of this fix patch as well, once a final version has been reached. Thanks, Ingo