From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
kgene@kernel.org, robh+dt@kernel.org, javier@osg.samsung.com,
niyas.ahmed@samsung.com, alim.akhtar@samsung.com,
pankaj.dubey@samsung.com
Subject: Re: [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie
Date: Wed, 1 Mar 2017 19:24:07 +0200 [thread overview]
Message-ID: <20170301172407.zuugioa7yjwbjl6r@kozik-lap> (raw)
In-Reply-To: <20170228070026.8725-1-jh80.chung@samsung.com>
On Tue, Feb 28, 2017 at 04:00:26PM +0900, Jaehoon Chung wrote:
> Add pcie-phy node for using phy-exynos-pcie.
>
> There are some modifications.
> 1. Remove the configuration space values in "ranges" property.
> - The getting configuration space from ranges is old way.
> - Instead, It can be got from "config"
>
> 2. Use the reg-names as "elbi", "config".
> - Can know the purpose of use with reg-names.
>
> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
> Reviewed-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> ---
> Changelog on V3:
> - Split from the patches relevant to pcie
> - Modify the commit-message
> - Keep the original comment in dt-file
> - Send this patch after applying the other patches
>
> Changelog on V2:
> - Removes the child-node
> - Fixes the typo
> - Removes the unnecessary comments
>
> arch/arm/boot/dts/exynos5440.dtsi | 30 ++++++++++++++++++++----------
> 1 file changed, 20 insertions(+), 10 deletions(-)
>
Looks okay. I'll apply it after merge window.
Best regards,
Krzysztof
next prev parent reply other threads:[~2017-03-01 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20170228070028epcas1p1dba363a5f02d2a6fd412679190f17139@epcas1p1.samsung.com>
2017-02-28 7:00 ` [PATCH V3] ARM: dts: exynos5440: support the phy-pcie node for pcie Jaehoon Chung
2017-03-01 17:24 ` Krzysztof Kozlowski [this message]
2017-03-07 20:05 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301172407.zuugioa7yjwbjl6r@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=javier@osg.samsung.com \
--cc=jh80.chung@samsung.com \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=niyas.ahmed@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).