From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753379AbdCAW4W (ORCPT ); Wed, 1 Mar 2017 17:56:22 -0500 Received: from mga05.intel.com ([192.55.52.43]:21777 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdCAW4S (ORCPT ); Wed, 1 Mar 2017 17:56:18 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,227,1484035200"; d="scan'208";a="63384319" Date: Wed, 1 Mar 2017 17:59:58 -0500 From: Keith Busch To: Logan Gunthorpe Cc: Bjorn Helgaas , linux-nvme@lists.infradead.org, Wei Zhang , Geert Uytterhoeven , Jonathan Corbet , linux-pci@vger.kernel.org, Greg Kroah-Hartman , Linus Walleij , Stefan Berger , Emil Velikov , linux-kernel@vger.kernel.org, Jarkko Sakkinen , linux-doc@vger.kernel.org, Stephen Bates , Myron Stowe , Kurt Schwemmer , Ryusuke Konishi , Bjorn Helgaas , Andrew Morton , Mauro Carvalho Chehab , "David S. Miller" , Guenter Roeck Subject: Re: [PATCH v5 0/4] New Microsemi PCI Switch Management Driver Message-ID: <20170301225958.GB14852@localhost.localdomain> References: <1488091997-12843-1-git-send-email-logang@deltatee.com> <20170301214120.GA30451@bhelgaas-glaptop.roam.corp.google.com> <20170301222651.GA14852@localhost.localdomain> <84556478-c01c-0925-be75-13a61d4c8f4f@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <84556478-c01c-0925-be75-13a61d4c8f4f@deltatee.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 01, 2017 at 03:37:03PM -0700, Logan Gunthorpe wrote: > On 01/03/17 03:26 PM, Keith Busch wrote: > > I think this is from using the managed device resource API to request the > > irq actions. The scope of the resource used to be tied to the pci_dev's > > dev, but now it's the new switchec class dev, which has a different > > lifetime while open references exist, so it's not releasing the irq's. > > The scope of the IRQ was originally tied to the pci_dev. Then in v4 I > tied it to the switchtec device in order to try and keep using the pci > device after unbind. This didn't work, so I switched it back to using > the pci_dev. (This seems to be the way most drivers work anyway.) Okay, I see. Was mistakenliy looking at v4. The v5 looks right.