From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753746AbdCAXNn (ORCPT <rfc822;w@1wt.eu>);
        Wed, 1 Mar 2017 18:13:43 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39844 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753278AbdCAXNm (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 1 Mar 2017 18:13:42 -0500
Date: Thu, 2 Mar 2017 00:13:34 +0100
From: Andrea Arcangeli <aarcange@redhat.com>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Michal Hocko <mhocko@suse.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Konstantin Khlebnikov <koct9i@gmail.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        "linux-mm@kvack.org" <linux-mm@kvack.org>,
        syzkaller <syzkaller@googlegroups.com>
Subject: Re: fs: use-after-free in userfaultfd_exit
Message-ID: <20170301231334.GO5816@redhat.com>
References: <CACT4Y+Z188Wehaes7iTo5m3PLiPgusj86f39kuN-O2HeDvQEWg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACT4Y+Z188Wehaes7iTo5m3PLiPgusj86f39kuN-O2HeDvQEWg@mail.gmail.com>
User-Agent: Mutt/1.7.2 (2016-11-26)
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 01 Mar 2017 23:13:37 +0000 (UTC)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 01, 2017 at 07:48:00PM +0100, Dmitry Vyukov wrote:
> Hello,
> 
> I've got the following use-after-free report while running syzkaller
> fuzzer on 86292b33d4b79ee03e2f43ea0381ef85f077c760:

Yes, I posted the fix for this one last Friday, I found it during
stress testing, it triggered the first time post-upstream merging
despite I was running the same stress testing with SLUB poisoning
enabled before.

This affects all apps, also the ones that don't use userfaultfd, it's
a locking issue. Furthermore the cost of userfaultfd_exit was not
acceptable, if something it had to be activated by a flag in mm->flags
(such an optimization would have been absolutely trivial though).

Thankfully I realized another feature (UFFDIO_COPY -ENOSPC retval) can
provide the same information at zero cost so I could drop
userfaultfd_exit as a whole.

https://marc.info/?l=linux-mm&m=148796041217814&w=2

The fix is already included in -mm along with the other fix for
VM_FAULT_NOPAGE.

Thanks,
Andrea