From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751548AbdCBVTR (ORCPT ); Thu, 2 Mar 2017 16:19:17 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:38544 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751260AbdCBVTP (ORCPT ); Thu, 2 Mar 2017 16:19:15 -0500 Date: Thu, 02 Mar 2017 12:47:58 -0800 (PST) Message-Id: <20170302.124758.1985678419997358947.davem@davemloft.net> To: alban.bedel@avionic-design.de Cc: netdev@vger.kernel.org, isubramanian@apm.com, kchudgar@apm.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drivers: net: xgene: Fix crash on DT systems From: David Miller In-Reply-To: <20170228170855.8123-1-alban.bedel@avionic-design.de> References: <20170228170855.8123-1-alban.bedel@avionic-design.de> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 02 Mar 2017 12:47:59 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alban Bedel Date: Tue, 28 Feb 2017 18:08:55 +0100 > On DT systems the driver require a clock, but the probe just print a > warning and continue, leading to a crash when resetting the device. > To fix this crash and properly handle probe deferals only ignore the > missing clock if DT isn't used or if the clock doesn't exist. > > Signed-off-by: Alban Bedel Applied, thanks.